From: Aaron Conole <aconole@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH -next 1/2] virtio: Start feature MTU support
Date: Thu, 02 Jun 2016 13:10:03 -0400 [thread overview]
Message-ID: <f7tinxrsej8.fsf@redhat.com> (raw)
In-Reply-To: <20160602191702-mutt-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 2 Jun 2016 19:17:17 +0300")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote:
>> This commit adds the feature bit and associated mtu device entry for the
>> virtio network device. Future commits will make use of these bits to
>> support negotiated MTU.
>
> why split it out? Pls squash with the next patch.
Okay. I thought the usual method was make a commit which introduces the
data structure changes, and then make a commit which hooks it up. I'll
squash this in the future.
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>> include/uapi/linux/virtio_net.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
>> index ec32293..751ff59 100644
>> --- a/include/uapi/linux/virtio_net.h
>> +++ b/include/uapi/linux/virtio_net.h
>> @@ -73,6 +73,8 @@ struct virtio_net_config {
>> * Legal values are between 1 and 0x8000
>> */
>> __u16 max_virtqueue_pairs;
>> + /* Default maximum transmit unit advice */
>> + __u16 mtu;
>> } __attribute__((packed));
>>
>> /*
>> --
>> 2.5.5
next prev parent reply other threads:[~2016-06-02 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 15:43 [PATCH -next 0/2] virtio-net: Advised MTU feature Aaron Conole
2016-06-02 15:43 ` [PATCH -next 1/2] virtio: Start feature MTU support Aaron Conole
2016-06-02 16:17 ` Michael S. Tsirkin
2016-06-02 17:10 ` Aaron Conole [this message]
2016-06-02 15:43 ` [PATCH -next 2/2] virtio_net: Read the advised MTU Aaron Conole
2016-06-02 16:16 ` Michael S. Tsirkin
2016-06-02 17:10 ` Aaron Conole
[not found] ` <5750578E.4040406@hpe.com>
2016-06-02 17:06 ` Aaron Conole
2016-06-02 18:02 ` Rick Jones
2016-06-02 17:25 ` kbuild test robot
2016-06-02 17:48 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tinxrsej8.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox