From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76334158D8D for ; Tue, 25 Jun 2024 13:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719321528; cv=none; b=BosEFnp3TK0l+G9QYZrVDk7GPkNXPxkADt0x88knMsFks+GO+16wlS+OpNnIpkcY6IaPJW17suaMEMi78vu6NjymWni84i7DGa/pOh1KEkzgODxfjA5URKS44uTjaiQC7IxNzOUtNunl/qwkDQicBIRxSdOml4fAogJlWljqpz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719321528; c=relaxed/simple; bh=hyBB6vBrNihLA68lQ1HJE9hCNJBLHhKrl6tOhM7ZdMA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YOQOOWZpB3XrTKBrZu4RMuqPRCKFDwkxrN1hhyeSbonoVTdRxCs//uWuF6XkeGTNoTQ8oSzUrHK/dVH0d9WPU+rqdoMvEK5G2tCimwr4F58Qohrbv0npyTehr6g930Hjg0XRgYU8TcHvwth7SB4FZz2ylsh9k1IRII3xaNcokzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PEMOcn0B; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PEMOcn0B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719321525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DvYqY+fCd4ATNyzlRN/MbCN6GKhU5kwtb/V7+EMg3zg=; b=PEMOcn0BRGTtEly1SC6EaOMQPoD+5/05kn4FbgNkYt29uz0prMEW3F+o9az9fUyxuaVsBe X9qXaUYqMB2TwnRvK9lBVKgmWlLVLnE5pGCkzyFFWcdEdYXoUxECvbOm8vrHZSYSrM86Km T2gjwvuo/kKBnVJflndXRLjSI0sb7WM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-E6boga1yNS-2FUioIakVlA-1; Tue, 25 Jun 2024 09:18:42 -0400 X-MC-Unique: E6boga1yNS-2FUioIakVlA-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 42D411956059; Tue, 25 Jun 2024 13:18:40 +0000 (UTC) Received: from RHTRH0061144 (dhcp-17-72.bos.redhat.com [10.18.17.72]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F253A3000225; Tue, 25 Jun 2024 13:18:37 +0000 (UTC) From: Aaron Conole To: Jakub Kicinski Cc: netdev@vger.kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Pravin B Shelar , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan , Stefano Brivio , =?utf-8?Q?Adri=C3=A1n?= Moreno , Simon Horman Subject: Re: [PATCH v2 net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script. In-Reply-To: <20240624153023.6fabd9f1@kernel.org> (Jakub Kicinski's message of "Mon, 24 Jun 2024 15:30:23 -0700") References: <20240620125601.15755-1-aconole@redhat.com> <20240621180126.3c40d245@kernel.org> <20240624153023.6fabd9f1@kernel.org> Date: Tue, 25 Jun 2024 09:18:36 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Jakub Kicinski writes: > On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote: >> Additionally, the "Cannot find device ..." text comes from an iproute2 >> utility output. The only place we actually interact with that is via >> the call at pmtu.sh:973: >> >> run_cmd ip link set ovs_br0 up >> >> Maybe it is possible that the link isn't up (could some port memory >> allocation or message be delaying it?) yet in the virtual environment. > > Depends on how the creation is implemented, normally device creation > over netlink is synchronous. Just to be sure have you tried to repro > with vng: > > https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style > > ? It could be the base OS difference, too, but that's harder to confirm. Yes - that's the way I run it. But I didn't try to use any of the stress inducing options. I'll work on it with that. >> To confirm, is it possible to run in the constrained environment, but >> put a 5s sleep or something? I will add the following either as a >> separate patch (ie 7/8), or I can fold it into 6/7 (and drop Stefano's >> ACK waiting for another review): >> >> >> wait_for_if() { >> if ip link show "$2" >/dev/null 2>&1; then return 0; fi >> >> for d in `seq 1 30`; do >> sleep 1 >> if ip link show "$2" >/dev/null 2>&1; then return 0; fi >> done >> return 1 >> } >> >> .... >> setup_ovs_br_internal || setup_ovs_br_vswitchd || return $ksft_skip >> + wait_for_if "ovs_br0" >> run_cmd ip link set ovs_br0 up >> .... >> >> Does it make sense or does it seem like I am way off base? > > sleep 1 is a bit high (sleep does accept fractional numbers!) > but otherwise worth trying, if you can't repro locally. Ack.