Netdev List
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Zhiling Zou <zhilinz@nebusec.ai>
Cc: netdev@vger.kernel.org,  dev@openvswitch.org,
	 echaudro@redhat.com, i.maximets@ovn.org,  davem@davemloft.net,
	 edumazet@google.com, pabeni@redhat.com,  horms@kernel.org,
	 pshelar@nicira.com, tgraf@suug.ch,  joestringer@nicira.com,
	 vega@nebusec.ai
Subject: Re: [PATCH net 1/1] openvswitch: avoid reallocating confirmed conntrack labels
Date: Tue, 15 Sep 2026 08:05:37 -0400	[thread overview]
Message-ID: <f7ty0d21zzi.fsf@aconole-thinkpadt14gen4.rmtusnh.csb> (raw)
In-Reply-To: <372fbb062b40ae6723684f55484be86ff0064f8e.1789218015.git.zhilinz@nebusec.ai> (Zhiling Zou's message of "Sat, 12 Sep 2026 21:22:43 +0800")

Zhiling Zou <zhilinz@nebusec.ai> writes:

> ovs_ct_get_conn_labels() adds the labels extension when a conntrack
> entry does not have one.  Confirmed conntracks can be read locklessly,
> so adding an extension may reallocate and free the extension block
> while another CPU accesses it.
>
> Only add the extension for unconfirmed conntracks.  A confirmed
> conntrack without labels now fails the caller's label operation instead
> of reallocating its extension storage.
>
> Fixes: c2ac66735870 ("openvswitch: Allow matching on conntrack label")
> Cc: stable@vger.kernel.org
> Reported-by: Vega <vega@nebusec.ai>
> Assisted-by: LLM
> Signed-off-by: Zhiling Zou <zhilinz@nebusec.ai>
> ---

Reviewed-by: Aaron Conole <aconole@redhat.com>


  parent reply	other threads:[~2026-09-15 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 13:22 [PATCH net 0/1] openvswitch: avoid reallocating confirmed conntrack labels Zhiling Zou
2026-09-12 13:22 ` [PATCH net 1/1] " Zhiling Zou
2026-09-14 21:44   ` Ilya Maximets
2026-09-15 12:05   ` Aaron Conole [this message]
2026-09-16  1:10 ` [PATCH net 0/1] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ty0d21zzi.fsf@aconole-thinkpadt14gen4.rmtusnh.csb \
    --to=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=joestringer@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pshelar@nicira.com \
    --cc=tgraf@suug.ch \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox