From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f226.google.com (mail-qk1-f226.google.com [209.85.222.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5FE623A566 for ; Thu, 30 Apr 2026 15:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777562468; cv=none; b=i9cHMi2rde870SsNEuNVdS1u6mKKWO4qC27BiDDFywWfrwMoVQpnxmd0ik4N+tY88y8UYldqbhDsYB+B7zlckWczrZV0OJ4RR2uAgkmB7IQtgGkDC/On1p1qJDEYocdzpkaF9qnVIz6Y3/8DRskbZ53x42XHdtjNenTdYhnSkkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777562468; c=relaxed/simple; bh=jfvurasXyO172rf8RueovQ21HocKi4qC6cmZUk6WC5A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OBhcD1xBdErJayU+VOA4hCTOo7oXkW+HVuh8/4v8isqK8unNTSGec14g5eeIgWoQs/RKSMTdDpvyLnA+jVsD1hWDmUzd7hO8arpm0bJORnTQXK8zxVYbhgWjUm1N9Jm71od/geKnFvbAoiV1qbr+PJbDbiBvb5FvAhvxv4BGEQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ZIwUFNgt; arc=none smtp.client-ip=209.85.222.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZIwUFNgt" Received: by mail-qk1-f226.google.com with SMTP id af79cd13be357-8f231f3b130so73897585a.3 for ; Thu, 30 Apr 2026 08:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777562466; x=1778167266; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j6W7N3TF0u0m9VhuQZcYonFJHVZpaP1eZOWODDM2/uM=; b=KKj9gFfbtUz8GOfwBPnsZ8XkPPHj5ljm0fKsVPO6s+jYKmfx+4ofcLCoFJK3vWy8a4 zkpIJB1rgQb79XIHYStjWxc+0+Nafb7OFnSgriQngIxRQesd1gApIWa3EsXE698PDcGX 789wXpO0q2sNJSKyvwkm9v5zknv4om91Lqjzeal/nVKni4uoSRV6RmHVKK6HOnrcvyvc KQRq+EQnE4S4YfhmkNOOf+sST3Fn4JYuR5fFW/liJp8JBdl2iRhv9NmS+KQAMS3mRqAN ktRGqU4efL2kr4W7z9a1xciQlhzEPBzcMi3UfHYEHaAgEGIknEipEhTp0NpC9hXnFtME kCZQ== X-Forwarded-Encrypted: i=1; AFNElJ/vbk4DplM/9yIYoVyYhueNDB6TjiFSx9gE+2uuYQ21g8gWy0A8XKXcGx8CKb+/jwVSb2Sqbwc=@vger.kernel.org X-Gm-Message-State: AOJu0YwDl+WClAuJwOjfBjdAUE9RLzo+gbt6kgodYr3OfqoYHwttBiaO XeCZ5T9qsFYWx7ftQowRA4OPx6525CkIvoSwcCU8m+v3bRQzGj+WA3eqVjlAwlN70wiH/yNT7bD Sgnt7nlRn7iS6s2nKa9wRyblZ//3eL9YZsKtw9LerGcZUO5ujmjzMNIXLy05xLJng4FR6T8n+1x CvVSQLCBs2tpL5rDbIP4b3NFulkwUk2tE0Og3Ipnu61g8C1vnCDk8XADQDyN0AGzSqNzouE/3Vo LICA2TaQ9UFJhXrfA== X-Gm-Gg: AeBDievKEgZNm5C0Qq4Ncbxe99t3HwNPcf0bgmFlOt8hz4Clm2nkIYA51DaP+gWoAhm tE/FB92GmQ5oXYwnojN4SLQtHx4Lpkgbsdv9IZoyNpLnIGTIXJB8RpbmQB4M0KKUturoTm/Tq3V lrGGh1MfVJyHbqFRvnd8sB9DUUiltc/7MZn7P+4qQ5fGanJZKFYX3yDx/GJ14hyxV4FN+cjSojr nscB4hxYVuucpc6T044O09v1Pst9XoPH6rO7E0B4GE+pbogk+dEx+JZ+SkMnbviV++gTopNDmJG AAw9DWQUgTosKfnZn1NpXvLVlk/B/hNNUNguN/Kg32vfMSMD7jUMYqfpGZPufW1pVPogdBDECOW G8Kc4/d2OVxu8BBjh0dB3DQ4QXOdInvuxtVeCjct/08tmDE9TNiz1IoINackmLL6o55OkfkG96w +Un9mRN0Kquo0W5hNcn8b88wLGcQYh8+p4GRrpwC1KF2vxubiru8NOCpkykIry2eIeVAFBEeY= X-Received: by 2002:ac8:58d2:0:b0:50e:6054:bc with SMTP id d75a77b69052e-5102ab43dc2mr48727221cf.16.1777562465341; Thu, 30 Apr 2026 08:21:05 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-21.dlp.protect.broadcom.com. [144.49.247.21]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-5103b597c61sm8101cf.21.2026.04.30.08.21.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Apr 2026 08:21:05 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-12c20d5d7f4so4081064c88.1 for ; Thu, 30 Apr 2026 08:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1777562464; x=1778167264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j6W7N3TF0u0m9VhuQZcYonFJHVZpaP1eZOWODDM2/uM=; b=ZIwUFNgt2V5XwCvofb+4td7FgcV00prd/59z7qF9PnpMXYvqXCF1cxUZ4RT0xitYVP VK7XaKqOpKcXPT8DMw7U1SRnThSvz0hZDPUcwg3mzezTLwChabwWZblydM31j6z8Elqp FlrUwQt2ib9JtjYZ10qTrOTHDW5jUQTiUhflA= X-Forwarded-Encrypted: i=1; AFNElJ8NcKjlndzoFiFIoIJygy0ECmkUo7MFkUe2lldnyexLT1dSzWh3EaY21A8j00QkFwikmazlJmc=@vger.kernel.org X-Received: by 2002:a05:7300:fd03:b0:2d9:7bc4:9578 with SMTP id 5a478bee46e88-2ed3e386a41mr1602819eec.28.1777562094275; Thu, 30 Apr 2026 08:14:54 -0700 (PDT) X-Received: by 2002:a05:7300:fd03:b0:2d9:7bc4:9578 with SMTP id 5a478bee46e88-2ed3e386a41mr1602745eec.28.1777562093564; Thu, 30 Apr 2026 08:14:53 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee38e71ccesm286774eec.10.2026.04.30.08.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 08:14:52 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 17:14:36 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marc Kleine-Budde , Vincent Mailhol , Krzysztof Halasa , Johannes Berg Cc: Markus Schneider-Pargmann , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Ido Schimmel , Sudarsana Kalluru , Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Petr Machata , Yibo Dong , Simon Horman , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Stanislav Yakovlev , Richard Cochran , Kees Cook , Thomas Gleixner , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Marco Crivellari , Vadim Fedorenko , Jacob Keller , Philipp Stanner , Bjorn Helgaas , Yeounsu Moon , Denis Benato , Peiyang Wang , Yonglong Liu , Andy Shevchenko , Yicong Hui , Randy Dunlap , MD Danish Anwar , Nathan Chancellor , Sai Krishna , Ethan Nelson-Moore , Larysa Zaremba , Joe Damato , Double Lo , Chi-hsien Lin , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 28/04/2026 19:18, Uwe Kleine-König (The Capable Hub) wrote: > ... and PCI device helpers. > > The various struct pci_device_id arrays were initialized mostly by one > the PCI_DEVICE macros and then list expressions. The latter isn't easily > readable if you're not into PCI. Using named initializers is more > explicit and thus easier to parse. > > Also use PCI_DEVICE* helper macros to assign .vendor, .device, > .subvendor and .subdevice where appropriate and skip explicit > assignments of 0 (which the compiler takes care of). > > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.com/) > and that requires named initializers. But it's also a nice cleanup on > its own. > > This change doesn't introduce changes to the compiled pci_device_id > arrays. Tested on x86 and arm64. for brcmfmac change... Acked-by: Arend van Spriel > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- [...] > .../broadcom/brcm80211/brcmfmac/pcie.c | 17 +- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 52 +- > 69 files changed, 1308 insertions(+), 1101 deletions(-)