From: David Ahern <dsahern@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Edward Cree <ecree@solarflare.com>
Subject: Re: [PATCH net-next v2 2/2] ipv4: use dst hint for ipv4 list receive
Date: Mon, 18 Nov 2019 09:07:21 -0700 [thread overview]
Message-ID: <f81feaf9-8792-a648-431f-be14e17e2ace@gmail.com> (raw)
In-Reply-To: <592c763828171c414e8927878b1a22027e33dee7.1574071944.git.pabeni@redhat.com>
On 11/18/19 4:01 AM, Paolo Abeni wrote:
> @@ -535,9 +540,20 @@ static void ip_sublist_rcv_finish(struct list_head *head)
> }
> }
>
> +static bool ip_can_cache_route_hint(struct net *net, struct rtable *rt)
> +{
> + return rt->rt_type != RTN_BROADCAST &&
> +#ifdef CONFIG_IP_MULTIPLE_TABLES
> + !net->ipv6.fib6_has_custom_rules;
that should be ipv4, not ipv6, right?
Also, for readability it would be better to have 2 helpers in
include//net/fib_rules.h that return true false and manage the net
namespace issue.
> +#else
> + 1;
> +#endif
> +}
> +
next prev parent reply other threads:[~2019-11-18 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 11:01 [PATCH net-next v2 0/2] net: introduce and use route hint Paolo Abeni
2019-11-18 11:01 ` [PATCH net-next v2 1/2] ipv6: introduce and uses route look hints for list input Paolo Abeni
2019-11-18 20:29 ` Willem de Bruijn
2019-11-18 21:58 ` Paolo Abeni
2019-11-19 14:10 ` Willem de Bruijn
2019-11-18 11:01 ` [PATCH net-next v2 2/2] ipv4: use dst hint for ipv4 list receive Paolo Abeni
2019-11-18 14:11 ` kbuild test robot
2019-11-18 16:07 ` David Ahern [this message]
2019-11-18 16:31 ` Paolo Abeni
2019-11-18 16:40 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f81feaf9-8792-a648-431f-be14e17e2ace@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).