From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH] ixgbe: fix Kconfig when driver is not a module Date: Thu, 03 Jan 2019 16:55:38 -0800 Message-ID: References: <20190103213519.9754-1-jeffrey.t.kirsher@intel.com> <9484abfd-0a07-31be-c738-6b770bbd3dc4@silicom-usa.com> Reply-To: jeffrey.t.kirsher@intel.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-XynZDsjHiNXLcK049+eu" Cc: "netdev@vger.kernel.org" , Dave Jones , Florian Fainelli To: Steve Douthit , "intel-wired-lan@lists.osuosl.org" Return-path: Received: from mga04.intel.com ([192.55.52.120]:25973 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726003AbfADAzk (ORCPT ); Thu, 3 Jan 2019 19:55:40 -0500 In-Reply-To: <9484abfd-0a07-31be-c738-6b770bbd3dc4@silicom-usa.com> Sender: netdev-owner@vger.kernel.org List-ID: --=-XynZDsjHiNXLcK049+eu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-01-04 at 00:00 +0000, Steve Douthit wrote: > Just tested this against a DSA dev in hardware and it works, but I > still think the simpler solution would be to just select PHYLIB: >=20 > diff --git a/drivers/net/ethernet/intel/Kconfig > b/drivers/net/ethernet/intel/Kconfig > index 31fb76ee9d82..a1246e89aad4 100644 > --- a/drivers/net/ethernet/intel/Kconfig > +++ b/drivers/net/ethernet/intel/Kconfig > @@ -159,7 +159,7 @@ config IXGBE > tristate "Intel(R) 10GbE PCI Express adapters support" > depends on PCI > select MDIO > - select MDIO_DEVICE > + select PHYLIB > imply PTP_1588_CLOCK > ---help--- > This driver supports Intel(R) 10GbE PCI Express family of >=20 > That seems to be the pattern for most of the other ethernet adapters: > $ grep -r 'select PHYLIB' drivers/net/ethernet/ | wc -l > 71 >=20 > vs checking MDIO_BUS (not counting this patch): > $ grep -r 'depends on.*MDIO_BUS' drivers/net/ethernet/ | wc -l > 0 I initially tried that, but we get a recursive Kconfig dependency error when IPSec is enabled as well, which I noted in the commit message. I agree the help text could be expanded to include the clause 22/45 address information, so I will submit a v2 of the patch. --=-XynZDsjHiNXLcK049+eu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlwurwoACgkQ5W/vlVpL 7c5XahAAgeNrxqrvRkpc67UkL/35BOj5hwyr7omfvgJpC7vIfrmD07hn/o5Uuhfs R7aypZ87FLiOP/+WIAZRiDblT+CsdvMFtWQmBUWsehq2bngskiqRfDshlY0Kb4MY wqb0OGpecVlejilyNiN+RsT0FUyiPiP3HYBY/0g+uyXRp7+MLd7wOIA5ow1xkcha ZRW6XqX5JCq1io2A/gagzXT8yZoXS33IK8ujT7tgq/pCB901nummz8B3jf4okbPk RE15SfZzgQDVv79BDZP13eD/cgMQH57yhvlyb9AgBgBATfnwCe8Tb71Tk8RM+g7a VjrEbaY52wsSlrbG5UAXGz5GRTWYiRkd9RXl4EGdsalojt7MJiNxzTIQRKxJgiFg Fkq9XxsuELFRF99BOSNiMEQ1ej2HZqQwwy2a4gmeu5Txl+bMqcgP8TGvLZMn6s1f cntA/12BJFXt6fMUR4j3O75jHsU0Mo8DvHONY7WZa2dfvlegyMzk6YXL5tgB1vhP w+cB7v9K6a9vKaWEshpMrb5JfZ6U6/O6X0ZPj0jfsQxXcYdyF1koCzFHv1iJBrSD TtJ156obWRU6erxicYUhxx9gGwOlHXpDDuMqPhffcp4R+/aQkOF0h+9OL+nceRUe Qz1XadXMcjh9k5YQpjYxqhOtFkf8UjxNX3lG8YcyTMdrKGlNg3c= =sQy9 -----END PGP SIGNATURE----- --=-XynZDsjHiNXLcK049+eu--