From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 bpf-next] bpf: test_bpf: add init_net to dev for
 flow_dissector
Date: Thu, 27 Sep 2018 09:39:04 -0700
Message-ID: <f83d10c4-b5fd-0223-e1b6-d376751c3da2@gmail.com>
References: <20180927163441.3918751-1-songliubraving@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: daniel@iogearbox.net, kernel-team@fb.com,
        Willem de Bruijn <willemb@google.com>,
        Petar Penkov <ppenkov@google.com>
To: Song Liu <songliubraving@fb.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lj1-f195.google.com ([209.85.208.195]:46344 "EHLO
        mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727320AbeI0W6P (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 27 Sep 2018 18:58:15 -0400
Received: by mail-lj1-f195.google.com with SMTP id 203-v6so3014173ljj.13
        for <netdev@vger.kernel.org>; Thu, 27 Sep 2018 09:39:09 -0700 (PDT)
In-Reply-To: <20180927163441.3918751-1-songliubraving@fb.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 09/27/2018 09:34 AM, Song Liu wrote:
> Latest changes in __skb_flow_dissect() assume skb->dev has valid nd_net.
> However, this is not true for test_bpf. As a result, test_bpf.ko crashes
> the system with the following stack trace:
> 
> This patch fixes tes_bpf by using init_net in the dummy dev.
> 
> Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Cc: Petar Penkov <ppenkov@google.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.