From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] net/neigh: fix NULL deref in pneigh_dump_table()
Date: Fri, 26 Oct 2018 11:07:30 -0600
Message-ID: <f85f6a3b-01bb-cf85-5147-154736df5ab6@gmail.com>
References: <20181026163327.219797-1-edumazet@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev <netdev@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f196.google.com ([209.85.215.196]:45529 "EHLO
        mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726113AbeJ0BpV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 26 Oct 2018 21:45:21 -0400
Received: by mail-pg1-f196.google.com with SMTP id s3-v6so807172pga.12
        for <netdev@vger.kernel.org>; Fri, 26 Oct 2018 10:07:33 -0700 (PDT)
In-Reply-To: <20181026163327.219797-1-edumazet@google.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/26/18 10:33 AM, Eric Dumazet wrote:
> pneigh can have NULL device pointer, so we need to make

hmmm.. missed that.

> neigh_master_filtered() and neigh_ifindex_filtered() more robust.
> 
...

> Fixes: 6f52f80e8530 ("net/neigh: Extend dump filter to proxy neighbor dumps")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: David Ahern <dsahern@gmail.com>
> Reported-by: syzbot <syzkaller@googlegroups.com>
> ---
>  net/core/neighbour.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Thanks for the fix

Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>