From: Manuel Lauss <manuel.lauss@googlemail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
manuel.lauss@gmail.com, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats()
Date: Tue, 6 Oct 2009 21:53:50 +0200 [thread overview]
Message-ID: <f861ec6f0910061253g28743e80r2db772aa7101f098@mail.gmail.com> (raw)
In-Reply-To: <4ACBA06A.6050208@gmail.com>
On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
> in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT.
> in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> please review, I merely guessed it should be RX_RUNT.
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index fdf5937..04f63c7 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status)
> ps->rx_errors++;
> if (status & RX_MISSED_FRAME)
> ps->rx_missed_errors++;
> - if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR))
> + if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR))
> ps->rx_length_errors++;
> if (status & RX_CRC_ERROR)
> ps->rx_crc_errors++;
> @@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev)
> printk("rx len error\n");
> if (status & RX_U_CNTRL_FRAME)
> printk("rx u control frame\n");
> - if (status & RX_MISSED_FRAME)
> - printk("rx miss\n");
Yeah, looks right.
Acked-by: Manuel Lauss <manuel.lauss@gmail.com>
Manuel Lauss
next prev parent reply other threads:[~2009-10-06 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 19:54 [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx_stats() Roel Kluin
2009-10-06 19:53 ` Manuel Lauss [this message]
2009-10-07 10:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f861ec6f0910061253g28743e80r2db772aa7101f098@mail.gmail.com \
--to=manuel.lauss@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=manuel.lauss@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox