From: Christian Lamparter <chunkeey@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Stable@vger.kernel.org
Subject: Re: [PATCH] carl9170: fix missing bit-wise or operator for tx_params
Date: Wed, 26 Jan 2022 21:03:33 +0100 [thread overview]
Message-ID: <f8721c22-03f2-6845-fe08-a552069eb55d@gmail.com> (raw)
In-Reply-To: <20220125004406.344422-1-colin.i.king@gmail.com>
On 25/01/2022 01:44, Colin Ian King wrote:
> Currently tx_params is being re-assigned with a new value and the
> previous setting IEEE80211_HT_MCS_TX_RX_DIFF is being overwritten.
> The assignment operator is incorrect, the original intent was to
> bit-wise or the value in. Fix this by replacing the = operator
> with |= instead.
>
> Kudos to Christian Lamparter for suggesting the correct fix.
>
> Fixes: fe8ee9ad80b2 ("carl9170: mac80211 glue and command interface")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Cc: <Stable@vger.kernel.org>
Of course:
Acked-by: Christian Lamparter <chunkeey@gmail.com>
next prev parent reply other threads:[~2022-01-26 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 0:44 [PATCH] carl9170: fix missing bit-wise or operator for tx_params Colin Ian King
2022-01-26 20:03 ` Christian Lamparter [this message]
2022-01-31 14:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8721c22-03f2-6845-fe08-a552069eb55d@gmail.com \
--to=chunkeey@gmail.com \
--cc=Stable@vger.kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).