From: Julian Anastasov <ja@ssi.bg>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Yingnan Zhang <342144303@qq.com>,
horms@verge.net.au, fw@strlen.de, phil@nwl.cc,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] ipvs: fix MTU check for GSO packets in tunnel mode
Date: Fri, 10 Apr 2026 09:51:31 +0300 (EEST) [thread overview]
Message-ID: <f8946f64-2d31-d792-e23a-3bd7566f0f17@ssi.bg> (raw)
In-Reply-To: <adhOOC6hF_vNDl1g@chamomile>
Hello,
On Fri, 10 Apr 2026, Pablo Neira Ayuso wrote:
> On Thu, Apr 02, 2026 at 10:46:16PM +0800, Yingnan Zhang wrote:
> > + } else if (skb->len > mtu &&
> > + !(skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu))) {
>
> Maybe helper function helps make this more readable?
>
> /* Based on ip_exceeds_mtu(). */
> static bool ip_vs_exceeds_mtu(const struct sk_buff *skb, unsigned int mtu)
> {
> if (skb->len <= mtu)
> return false;
>
> if (skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu))
> return false;
>
> return true;
> }
Good idea! Yingnan Zhang, please send v4 by adding
this new function before __mtu_check_toobig_v6()...
Regards
--
Julian Anastasov <ja@ssi.bg>
prev parent reply other threads:[~2026-04-10 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 14:46 [PATCH net v3] ipvs: fix MTU check for GSO packets in tunnel mode Yingnan Zhang
2026-04-03 14:20 ` Julian Anastasov
2026-04-10 1:11 ` Pablo Neira Ayuso
2026-04-10 6:51 ` Julian Anastasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8946f64-2d31-d792-e23a-3bd7566f0f17@ssi.bg \
--to=ja@ssi.bg \
--cc=342144303@qq.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox