From: David Ahern <dsahern@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [PATCH net-next v2] net: core: change bool members of struct net_device to bitfield members
Date: Tue, 9 Oct 2018 14:43:27 -0600 [thread overview]
Message-ID: <f8bbbd11-0ad2-77e6-c4fe-e3f643e7e243@gmail.com> (raw)
In-Reply-To: <ded0a778-ca20-4e0f-223d-da3eb5cd71b2@gmail.com>
On 10/9/18 2:24 PM, Heiner Kallweit wrote:
> Reordering the struct members to fill the holes could be a little tricky
> and could have side effects because it may make a performance difference
> whether certain members are in one cacheline or not.
> And whether it's worth to spend this effort (incl. the related risks)
> just to save a few bytes (also considering that typically we have quite
> few instances of struct net_device)?
>
It would be good to get net_device below 2048 without affecting
performance. Anything else is just moving elements around for the same
end allocation (rounds up to 4096).
next prev parent reply other threads:[~2018-10-10 4:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 20:17 [PATCH net-next v2] net: core: change bool members of struct net_device to bitfield members Heiner Kallweit
2018-10-09 15:20 ` David Ahern
2018-10-09 20:24 ` Heiner Kallweit
2018-10-09 20:43 ` David Ahern [this message]
2018-10-09 20:52 ` Eric Dumazet
2018-10-10 8:59 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bbbd11-0ad2-77e6-c4fe-e3f643e7e243@gmail.com \
--to=dsahern@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).