[PATCH v3] iproute2: color: default to dark background

Gedalya Nie
2024-05-22T21:10:23Z

Since the COLORFGBG environment variable isn't always there, and
anyway it seems that terminals and consoles more commonly default
to dark backgrounds, make that assumption here.

Currently the iproute2 tools produce output that is hard to read
when color is enabled and the background is dark.

Signed-off-by: Gedalya Nie <gedalya@gedalya.net>
---
lib/color.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/color.c b/lib/color.c
index cd0f9f75..6692f9c1 100644
--- a/lib/color.c
+++ b/lib/color.c
@@ -72,7 +72,7 @@ static enum color attr_colors_dark[] = {
C_CLEAR
};

-static int is_dark_bg;
+static int is_dark_bg = 1;
static int color_is_enabled;

static void enable_color(void)
@@ -127,11 +127,11 @@ static void set_color_palette(void)
* COLORFGBG environment variable usually contains either two or three
* values separated by semicolons; we want the last value in either case.
* If this value is 0-6 or 8, background is dark.
+ * If it is 7, 9 or greater, background is light.
*/
if (p && (p = strrchr(p, ';')) != NULL
- && ((p[1] >= '0' && p[1] <= '6') || p[1] == '8')
- && p[2] == '\0')
- is_dark_bg = 1;
+ && (p[1] == '7' || p[1] == '9' || p[2] != '\0'))
+ is_dark_bg = 0;
}

__attribute__((format(printf, 3, 4)))
--
2.43.0