From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mohammed Gamal <mgamal@redhat.com>, netdev@vger.kernel.org
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
sthemmin@microsoft.com, davem@davemloft.net, vkuznets@redhat.com,
otubo@redhat.com
Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast
Date: Fri, 9 Mar 2018 21:38:28 +0300 [thread overview]
Message-ID: <f91486d9-92de-4a67-f02c-358c1a503f6e@cogentembedded.com> (raw)
In-Reply-To: <6fcea84b-505b-68bc-709c-d793802f7f6d@cogentembedded.com>
On 03/09/2018 09:37 PM, Sergei Shtylyov wrote:
>> Commit 009f766 intended to filter multicast/broadcast, however
>
> At least 12 digits needed here, and the summary line too, just like you do
> for the Fixes: tag.
>
>> the NDIS filter wasn't set properly in non-promiscuous modes,
>> which resulted in issues like DHCP timeouts.
>> This patch sets the filter flags correctly.
>>
>> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
12 digits needed here as well.
>>
>> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> [...]
MBR, Sergei
next prev parent reply other threads:[~2018-03-09 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 13:25 [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast Mohammed Gamal
2018-03-09 18:37 ` Sergei Shtylyov
2018-03-09 18:38 ` Sergei Shtylyov [this message]
[not found] <1520594542-24257-1-git-send-email-mgamal@redhat.com>
2018-03-09 15:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f91486d9-92de-4a67-f02c-358c1a503f6e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).