From: David Ahern <dsa@cumulusnetworks.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Kostya Serebryany <kcc@google.com>,
Eric Dumazet <edumazet@google.com>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: net/tcp: null-ptr-deref in __inet_lookup_listener/inet_exact_dif_match
Date: Wed, 2 Nov 2016 12:31:20 -0600 [thread overview]
Message-ID: <f92b8a3e-9318-90c4-009a-15da3897ff6b@cumulusnetworks.com> (raw)
In-Reply-To: <1478107305.7065.382.camel@edumazet-glaptop3.roam.corp.google.com>
On 11/2/16 11:21 AM, Eric Dumazet wrote:
> Thanks for your report.
>
> David, please take a look.
>
> TCP MD5 can call __inet_lookup_listener() with a NULL skb.
interesting. I did not test md5 before sending, but doing so now I am not able to trigger the panic with any combination of passwords - correct, wrong, none, no listener, etc. perhaps I am missing a sysctl setting.
Will send a fix. I see the call to __inet_lookup_listener with null skb.
>
> Bug added in commit a04a480d4392ea6efd117be2de564117b2a009c0
next prev parent reply other threads:[~2016-11-02 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 17:01 net/tcp: null-ptr-deref in __inet_lookup_listener/inet_exact_dif_match Andrey Konovalov
2016-11-02 17:21 ` Eric Dumazet
2016-11-02 18:31 ` David Ahern [this message]
2016-11-02 18:36 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92b8a3e-9318-90c4-009a-15da3897ff6b@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kcc@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox