From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip: promote missed packets to the -s row
Date: Fri, 18 Sep 2020 22:52:56 -0600 [thread overview]
Message-ID: <f936dedf-ee3a-976c-c535-55a2b075b37b@gmail.com> (raw)
In-Reply-To: <20200918084826.14d2cea3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 9/18/20 9:48 AM, Jakub Kicinski wrote:
> On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote:
>> On 9/16/20 1:42 PM, Jakub Kicinski wrote:
>>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
>>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff
>>> RX: bytes packets errors dropped overrun mcast
>>> 6.04T 4.67G 0 0 0 67.7M
>>> RX errors: length crc frame fifo missed
>>> 0 0 0 0 7
>>> TX: bytes packets errors dropped carrier collsns
>>> 3.13T 2.76G 0 0 0 0
>>> TX errors: aborted fifo window heartbeat transns
>>> 0 0 0 0 6
>>>
>>> After:
>>>
>>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
>>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff
>>> RX: bytes packets errors dropped missed mcast
>>> 6.04T 4.67G 0 0 7 67.7M
>>> RX errors: length crc frame fifo overrun
>>> 0 0 0 0 0
>>> TX: bytes packets errors dropped carrier collsns
>>> 3.13T 2.76G 0 0 0 0
>>> TX errors: aborted fifo window heartbeat transns
>>> 0 0 0 0 6
>>
>> changes to ip output are usually not allowed.
>
> Does that mean "no" or "you need to be more convincing"? :)
>
> JSON output is not changed. I don't think we care about screen
> scrapers. If we cared about people how interpret values based
> on their position in the output we would break that with every
> release, no?
>
In this case you are not adding or inserting a new column, you are
changing the meaning of an existing column.
It's an 'error' stat so probably not as sensitive. I do not have a
strong religion on it since it seems to be making the error stat more up
to date.
next prev parent reply other threads:[~2020-09-19 4:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 19:42 [PATCH iproute2-next] ip: promote missed packets to the -s row Jakub Kicinski
2020-09-18 15:44 ` David Ahern
2020-09-18 15:48 ` Jakub Kicinski
2020-09-19 4:52 ` David Ahern [this message]
2020-09-19 16:06 ` Stephen Hemminger
2020-09-21 21:49 ` Jakub Kicinski
2020-09-23 2:24 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f936dedf-ee3a-976c-c535-55a2b075b37b@gmail.com \
--to=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).