[PATCH 0/3] Add ethernet dts schema for qcs615/qcs8300

[PATCH 0/3] Add ethernet dts schema for qcs615/qcs8300

[Yijie Yang]

Document the ethernet and SerDes compatible for qcs8300. This platform
shares the same EMAC and SerDes as sa8775p, so the compatible fallback to
it.
Document the ethernet compatible for qcs615. This platform shares the
same EMAC as sm8150, so the compatible fallback to it.
Document the compatible for revision 2 of the qcs8300-ride board.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
This patch series depends on below patch series:
https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/

---
Yijie Yang (3):
      dt-bindings: net: qcom,ethqos: add description for qcs615
      dt-bindings: phy: describe the Qualcomm SGMII PHY
      dt-bindings: net: qcom,ethqos: add description for qcs8300

 .../devicetree/bindings/net/qcom,ethqos.yaml          | 19 ++++++++++++++-----
 .../bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml    |  7 ++++++-
 2 files changed, 20 insertions(+), 6 deletions(-)
---
base-commit: 70c6ab36f8b7756260369952a3c13b3362034bd1
change-id: 20241010-schema-50b0b777c28b

Best regards,
-- 
Yijie Yang <quic_yijiyang@quicinc.com>

[PATCH 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615

[Yijie Yang]

Add compatible for the MAC controller on qcs615 platform.
Since qcs615 shares the same EMAC as sm8150, so it fallback to that
compatible.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
 Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 6672327358bc..8cf29493b822 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -18,11 +18,16 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - qcom,qcs404-ethqos
-      - qcom,sa8775p-ethqos
-      - qcom,sc8280xp-ethqos
-      - qcom,sm8150-ethqos
+    oneOf:
+      - items:
+          - enum:
+              - qcom,qcs615-ethqos
+          - const: qcom,sm8150-ethqos
+      - enum:
+          - qcom,qcs404-ethqos
+          - qcom,sa8775p-ethqos
+          - qcom,sc8280xp-ethqos
+          - qcom,sm8150-ethqos
 
   reg:
     maxItems: 2

-- 
2.34.1

Re: [PATCH 1/3] dt-bindings: net: qcom,ethqos: add description for qcs615

[Krzysztof Kozlowski]

On Thu, Oct 10, 2024 at 10:03:43AM +0800, Yijie Yang wrote:
> Add compatible for the MAC controller on qcs615 platform.
> Since qcs615 shares the same EMAC as sm8150, so it fallback to that
> compatible.
> 
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY

[Yijie Yang]

Describe the SGMII/SerDes PHY present on the qcs8300 platforms. Since
qcs8300 shares the same SerDes as sa8775p, so it fallback to the
compatible.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
 .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml      | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
index b9107759b2a5..90fc8c039219 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
@@ -15,7 +15,12 @@ description:
 
 properties:
   compatible:
-    const: qcom,sa8775p-dwmac-sgmii-phy
+    oneOf:
+      - items:
+          - enum:
+              - qcom,qcs8300-dwmac-sgmii-phy
+          - const: qcom,sa8775p-dwmac-sgmii-phy
+      - const: qcom,sa8775p-dwmac-sgmii-phy
 
   reg:
     items:

-- 
2.34.1

Re: [PATCH 2/3] dt-bindings: phy: describe the Qualcomm SGMII PHY

[Krzysztof Kozlowski]

On Thu, Oct 10, 2024 at 10:03:44AM +0800, Yijie Yang wrote:
> Describe the SGMII/SerDes PHY present on the qcs8300 platforms. Since
> qcs8300 shares the same SerDes as sa8775p, so it fallback to the
> compatible.
> 
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
>  .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml      | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

[Yijie Yang]

Add compatible for the MAC controller on qcs8300 platforms.
Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
compatible.

Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
 Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 8cf29493b822..3ee5367bdde1 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -23,6 +23,10 @@ properties:
           - enum:
               - qcom,qcs615-ethqos
           - const: qcom,sm8150-ethqos
+      - items:
+          - enum:
+              - qcom,qcs8300-ethqos
+          - const: qcom,sa8775p-ethqos
       - enum:
           - qcom,qcs404-ethqos
           - qcom,sa8775p-ethqos

-- 
2.34.1

Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

[Krzysztof Kozlowski]

On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
> Add compatible for the MAC controller on qcs8300 platforms.
> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
> compatible.
> 
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 8cf29493b822..3ee5367bdde1 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -23,6 +23,10 @@ properties:
>            - enum:
>                - qcom,qcs615-ethqos
>            - const: qcom,sm8150-ethqos
> +      - items:
> +          - enum:
> +              - qcom,qcs8300-ethqos
> +          - const: qcom,sa8775p-ethqos

This block should go before earlier qcs615, to keep order by fallback.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

[Yijie Yang]

On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>> Add compatible for the MAC controller on qcs8300 platforms.
>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>> compatible.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> index 8cf29493b822..3ee5367bdde1 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>> @@ -23,6 +23,10 @@ properties:
>>             - enum:
>>                 - qcom,qcs615-ethqos
>>             - const: qcom,sm8150-ethqos
>> +      - items:
>> +          - enum:
>> +              - qcom,qcs8300-ethqos
>> +          - const: qcom,sa8775p-ethqos
> 
> This block should go before earlier qcs615, to keep order by fallback.

Why this block should positioned before qcs615, given that it comes 
later in alphabetical order?

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

[Krzysztof Kozlowski]

On 15/10/2024 08:21, Yijie Yang wrote:
> 
> 
> On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>>> Add compatible for the MAC controller on qcs8300 platforms.
>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>>> compatible.
>>>
>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> index 8cf29493b822..3ee5367bdde1 100644
>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>> @@ -23,6 +23,10 @@ properties:
>>>             - enum:
>>>                 - qcom,qcs615-ethqos
>>>             - const: qcom,sm8150-ethqos
>>> +      - items:
>>> +          - enum:
>>> +              - qcom,qcs8300-ethqos
>>> +          - const: qcom,sa8775p-ethqos
>>
>> This block should go before earlier qcs615, to keep order by fallback.

--------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^

Here

> 
> Why this block should positioned before qcs615, given that it comes 
> later in alphabetical order?

sa < sm

Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings: net: qcom,ethqos: add description for qcs8300

[Yijie Yang]

On 2024-10-15 14:27, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:21, Yijie Yang wrote:
>>
>>
>> On 2024-10-10 14:15, Krzysztof Kozlowski wrote:
>>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote:
>>>> Add compatible for the MAC controller on qcs8300 platforms.
>>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the
>>>> compatible.
>>>>
>>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> index 8cf29493b822..3ee5367bdde1 100644
>>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>>> @@ -23,6 +23,10 @@ properties:
>>>>              - enum:
>>>>                  - qcom,qcs615-ethqos
>>>>              - const: qcom,sm8150-ethqos
>>>> +      - items:
>>>> +          - enum:
>>>> +              - qcom,qcs8300-ethqos
>>>> +          - const: qcom,sa8775p-ethqos
>>>
>>> This block should go before earlier qcs615, to keep order by fallback.
> 
> --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^
> 
> Here
> 
>>
>> Why this block should positioned before qcs615, given that it comes
>> later in alphabetical order?
> 
> sa < sm

Understood, thanks.

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Yijie