fq_codel and skb->hash

[Andrew Collins <acollins@cradlepoint.com>]

The fq_codel packet scheduler always regenerates the skb flow hash.  Is there any reason
to do this other than the recent hash perturbation additions?

I ask because I have a case where an incoming set of TCP flows is encapsulated in a
single ipsec tunnel, which is then classified on egress into a single flow by fq_codel
resulting in poor behavior.

Reusing the skb hash set in receive results in much better behavior, as the value is
determined pre-encapsulation and flows end up being distributed more naturally across
codel queues.

Is opportunistically using the pre-existing skb hash (if available) problematic?  Is
there a better way to manage flow separation in routed+encapsulated traffic?

Thanks,
Andrew Collins