From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 096253F9F4B for ; Wed, 6 May 2026 13:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778072697; cv=none; b=g29Xau1nBiG0hpTZxQocvHgorKvdcZv3mxBlYD5xKriO5/CI1bFDLAdzz49CuO3QKqtgDc2JiZW6T7gzKqqdLoWIMn8MXpRdZBxk80ZKtYS1hwhnpw+WPs5ME/ZFRlQiqV99en1MYIjm+0B27rHuoT9IsbMe3boZYIKhYF32qFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778072697; c=relaxed/simple; bh=7vf9+i6AHyONbumqmEideqiYlV6PkC+bLroWjZP/9e4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U/e6YDIqDrhRBrvtBxKi3v5mh7f2l12cBI7HIL+NWwCgWaEYi8dH8z3y1sinNvsiartzcty/k1giVs1Gy5OlmzhVUyNWIokJnY99g1/ShUX4qZeRmNyqPlcQro4wv9B/kXueo2s3S6vRO1OjxohLFgP3ky2Io1TaHiGJUXxKi+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=uw7/ezzI; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="uw7/ezzI" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 26758C5DC4A for ; Wed, 6 May 2026 13:05:32 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D93A16053C; Wed, 6 May 2026 13:04:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B9290102F24CF; Wed, 6 May 2026 15:04:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1778072684; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=/+T6umy0cooM1bnJ96FCKLXxkBj53jFxTV9fG9xlUUE=; b=uw7/ezzItWXZd6VOaFfgqWWjKBh08wozppnv6qGzVuNdf8MgR0ewetkTMHZVVvnpft/YCG MPK6vyqMy4sByAhxftcmPFm53dui1ihbOgBTjEjaoAqHgKERsW7QL1RknZXpKJgS7hArEq sBjAWIdNb2xqRwRD2kwcwUIfd9ViuBj9O/AQfTuPmMmVjA/rxkMv5280u3sC7+bjIXEXHc fYaHXE/2+BFsnHj/J84BbAbtBGn3ibn8SzN+NAtwWqaR/1AynJDzw1kfUcSUyVmiOhJsnO gnnTI5xHCz4LF9/JeIRfhhHeyrUQDJaM5IeRhwDWkKHHBRc/SBdL6rXQR1FZnA== Message-ID: Date: Wed, 6 May 2026 15:04:42 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: assert in phylink.c with lan7801 and dp83tc811 since kernel 6.18 To: Andrew Lunn , Sven Schuchmann Cc: "netdev@vger.kernel.org" References: <57fb63c2-7a05-4bbe-ba2d-fc61ce1e3ba1@lunn.ch> <7778cd41-cf36-4524-a347-408a8fb0bde0@lunn.ch> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <7778cd41-cf36-4524-a347-408a8fb0bde0@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 06/05/2026 14:39, Andrew Lunn wrote: >> So for me it somewhere happens in phylink_validate_mac_and_pcs() > > I was expecting to see more debug output, but reading the code, i was > also thinking we need to look at phylink_validate_mac_and_pcs(). > > You are going in the correct direction putting lots of printk() in the > code. We need to find where it returns EINVAL: [...] > > In the end, we are probably going to find that what the MAC says its > capabilities are don't match what the PCS says it can do. > > Thinking about that, it says phy mode RGMII. You generally don't use a > PCS with RGMII, so that is suspicious. > Another thing to consider is that in this case, we're attaching to a dp83tc811, so a 100BaseT1 PHY. Does the PHY driver correctly populates the supported features ? Could be that we're getting an empty-ish phydev->supported after reading the abilities, as this is not a typical BaseT PHY Maxime