From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0205839FCB4 for ; Thu, 16 Apr 2026 11:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776338734; cv=none; b=YVu9FU8ckUf6MwXuTsPGBd3+rtzdl7eCcc3nX98z4L2ChOxOsTYXQSelkGrBAPMCH950nuZmo01qWstdUpTHTgwJibalsFQwGuaRk11dYoSzK37pSSCXj4ph3ZSAQOTDNA5aUZMcBSzKn0tS2QB7nFKEMPwfKlAXwUVSKdnNYqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776338734; c=relaxed/simple; bh=MDT0EpxI7FYj3XC7ziE+as+s2FSA367oMU36RFoC930=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BFFbIaWvBOj1nqf84//u4YpGtPdU+ddgAS7wvOHHLWb4g3IgtX1j5dOjGH2a8L/wC5te7LacQEpXhXRJBBmI0OFEgWoXHoNBLdm+IOpo8VBHxBEjDZ7Qf4CHplXebXUaFLuPPM7mjfwRoNfHuDJ6Q8U8OGhukbK/9+Xc5EJ1esA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XfAAfkit; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=429nCgNW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XfAAfkit; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=429nCgNW; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XfAAfkit"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="429nCgNW"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XfAAfkit"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="429nCgNW" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3DA7C5BE53; Thu, 16 Apr 2026 11:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776338731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKaq1Gag/E7c4D6ZKnA1WevGKpgHO+6fri2e2955kF8=; b=XfAAfkit6o/17ymBcAzkF3pLyc8Eq1v2mTaQeGZ6ZXnyUqVuJB+BcZov1wH5A1Xk5AsM7H 4NaWCqotxsMUwv0NrM/noNbEEofneBpa3zEqB8qLHrR3IHKQnRGVuH3TKchQhcIs7LTzn2 E3HcjgRHSuUfD2rZhEXCoMamCsFU3b4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776338731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKaq1Gag/E7c4D6ZKnA1WevGKpgHO+6fri2e2955kF8=; b=429nCgNWpjslEElsIuc6qH1VO4o2NTzQ5wTf1CTWDLQsWO0cOg9eBD4Gd72j9omUNCJ8X9 hNC5SYjD72lLy+Aw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776338731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKaq1Gag/E7c4D6ZKnA1WevGKpgHO+6fri2e2955kF8=; b=XfAAfkit6o/17ymBcAzkF3pLyc8Eq1v2mTaQeGZ6ZXnyUqVuJB+BcZov1wH5A1Xk5AsM7H 4NaWCqotxsMUwv0NrM/noNbEEofneBpa3zEqB8qLHrR3IHKQnRGVuH3TKchQhcIs7LTzn2 E3HcjgRHSuUfD2rZhEXCoMamCsFU3b4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776338731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKaq1Gag/E7c4D6ZKnA1WevGKpgHO+6fri2e2955kF8=; b=429nCgNWpjslEElsIuc6qH1VO4o2NTzQ5wTf1CTWDLQsWO0cOg9eBD4Gd72j9omUNCJ8X9 hNC5SYjD72lLy+Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B6D89593A3; Thu, 16 Apr 2026 11:25:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3fa6KSrH4GkiXgAAD6G6ig (envelope-from ); Thu, 16 Apr 2026 11:25:30 +0000 Message-ID: Date: Thu, 16 Apr 2026 13:25:08 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] ipv6: fix possible UAF in icmpv6_rcv() To: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , David Ahern , Ido Schimmel , netdev@vger.kernel.org, eric.dumazet@gmail.com References: <20260416103505.2380753-1-edumazet@google.com> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260416103505.2380753-1-edumazet@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[9]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,nvidia.com,vger.kernel.org,gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: On 4/16/26 12:35 PM, Eric Dumazet wrote: > Caching saddr and daddr before pskb_pull() is problematic > since skb->head can change. > > Remove these temporary variables: > > - We only access &ipv6_hdr(skb)->saddr and &ipv6_hdr(skb)->daddr > when net_dbg_ratelimited() is called in the slow path. > > - Avoid potential future misuse after pskb_pull() call. > > Fixes: 4b3418fba0fe ("ipv6: icmp: include addresses in debug messages") > Signed-off-by: Eric Dumazet Reviewed-by: Fernando Fernandez Mancera Thanks!