From: Edward Cree <ecree.xilinx@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
ecree@xilinx.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, habetsm.xilinx@gmail.com,
marcelo.leitner@gmail.com
Subject: Re: [RFC PATCH net-next 1/3] netlink: add support for formatted extack messages
Date: Fri, 7 Oct 2022 14:58:42 +0100 [thread overview]
Message-ID: <f9bb2d52-c7f6-5aaa-37e5-59e7a2ff4a8e@gmail.com> (raw)
In-Reply-To: <ff12253b6855305cc3fa518af30e8ac21019b684.camel@sipsolutions.net>
On 07/10/2022 14:49, Johannes Berg wrote:
> Unless maybe we printed a warning together with the full string, so the
> user could recover it?
Ooh, I like that.
Would need to net_ratelimit of course, but that should be easy enough.
It's not quite perfect as it'd evaluate the VA_ARGS twice, potentially
side-effecting, which the original NL_SET_ERR_MSG() took some care to
avoid, but I think we can live with that.
-ed
next prev parent reply other threads:[~2022-10-07 13:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:25 [RFC PATCH net-next 0/3] netlink: formatted extacks ecree
2022-10-07 13:25 ` [RFC PATCH net-next 1/3] netlink: add support for formatted extack messages ecree
2022-10-07 13:35 ` Johannes Berg
2022-10-07 13:46 ` Edward Cree
2022-10-07 13:49 ` Johannes Berg
2022-10-07 13:58 ` Edward Cree [this message]
2022-10-13 12:59 ` Jiri Pirko
2022-10-13 13:35 ` Edward Cree
2022-10-07 18:32 ` Jakub Kicinski
2022-10-13 12:55 ` Jiri Pirko
2022-10-17 12:00 ` Edward Cree
2022-10-17 18:44 ` Jakub Kicinski
2022-10-07 13:25 ` [RFC PATCH net-next 2/3] sfc: use formatted extacks instead of efx_tc_err() ecree
2022-10-07 13:25 ` [RFC PATCH net-next 3/3] sfc: remove 'log-tc-errors' ethtool private flag ecree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9bb2d52-c7f6-5aaa-37e5-59e7a2ff4a8e@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree@xilinx.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).