From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 391A718CBED; Wed, 31 Jul 2024 08:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722415785; cv=none; b=NElvX5v5hMXc9wdOQJ3+VE0RV7dNG5baSGZJHwuEzhz4IBdBjngUuyCrodv7AipXpeqClc8lri8NiVQZif6eym6/1UHbe/4TI64bHRL58dT73IP6C/W6AwMIaJhbeAgD0z7SyUm7G6IcLdMzyA3meQvivnc+8rIrmVcBgKi/vYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722415785; c=relaxed/simple; bh=zcTY/GqUfYE3yguTn78cETVE64YCw8EsY/LDEWceEGU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oaZ6ISh2ll32x5F9aF4NAqb1ArWQQX4Mktk53f95QQNDpo4eGAcl98/P8cM+OLpKdP6HoLC+Zmh3ylKvN5To+qM19H18kafvw1OoxxeD0J6GmvAV9aSEW+jRHzb9jELuiVsWFbRDcYIHVWRHJTfrEtcn6z/WClctNZdkUEDo/+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=MZPw1gAC; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="MZPw1gAC" Received: from [100.79.192.202] (unknown [4.194.122.170]) by linux.microsoft.com (Postfix) with ESMTPSA id A9A4C20B7165; Wed, 31 Jul 2024 01:49:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A9A4C20B7165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1722415781; bh=RDk+WVHxBeUm3xVFN39EW1/JZAEiQ71Gmv+Q/rbsnL4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MZPw1gACS8IkH89ctCMI5myecTJmMMcsK4MTAYUmAysGgVORi25CgqwXS45wxqvuS hfNy9DrWgSCIz2Wdh3uEMS80Foo6phzbkBrL4fP3qs6T4CA83aLFUyzweEZfaLq5iV pms0fjhLBpZT7waSSOnPZJ+muOhaE6PuPwX/hZIE= Message-ID: Date: Wed, 31 Jul 2024 14:19:34 +0530 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] net: mana: Implement get_ringparam/set_ringparam for mana To: Shradha Gupta , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Long Li , Ajay Sharma , Simon Horman , Konstantin Taranov , Souradeep Chakrabarti , Erick Archer , Pavan Chebbi , Ahmed Zaki , Colin Ian King References: <1722358895-13430-1-git-send-email-shradhagupta@linux.microsoft.com> Content-Language: en-US From: Naman Jain In-Reply-To: <1722358895-13430-1-git-send-email-shradhagupta@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/30/2024 10:31 PM, Shradha Gupta wrote: > Currently the values of WQs for RX and TX queues for MANA devices > are hardcoded to default sizes. > Allow configuring these values for MANA devices as ringparam > configuration(get/set) through ethtool_ops. > > Signed-off-by: Shradha Gupta > Reviewed-by: Haiyang Zhang > Reviewed-by: Long Li > --- > Changes in v2: > * Removed unnecessary validations in mana_set_ringparam() > * Fixed codespell error > * Improved error message to indicate issue with the parameter > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 20 +++--- > .../ethernet/microsoft/mana/mana_ethtool.c | 66 +++++++++++++++++++ > include/net/mana/mana.h | 21 +++++- > 3 files changed, 96 insertions(+), 11 deletions(-) > From what I understand, we are adding support for "ethtool -G --set- ring" command. Please correct me if I am wrong. Maybe it would be good to capture the benefit/purpose of this patch in the commit msg, as in which use-cases/scenarios we are now trying to support that previously were not supported. The "why?" part basically. Regards, Naman Jain