From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next v2 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror Date: Fri, 27 Apr 2018 18:39:09 +0300 Message-ID: References: <20180427151111.22099-1-idosch@mellanox.com> <20180427151111.22099-7-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, stephen@networkplumber.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org, bridge@lists.linux-foundation.org Return-path: Received: from mail-wr0-f176.google.com ([209.85.128.176]:34551 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932922AbeD0PjM (ORCPT ); Fri, 27 Apr 2018 11:39:12 -0400 Received: by mail-wr0-f176.google.com with SMTP id p18-v6so2200580wrm.1 for ; Fri, 27 Apr 2018 08:39:11 -0700 (PDT) In-Reply-To: <20180427151111.22099-7-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 27/04/18 18:11, Ido Schimmel wrote: > From: Petr Machata > > When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the > underlay address (i.e. the remote address of the tunnel) may be routed > to a bridge. > > In that case, look up the resolved neighbor Ethernet address in that > bridge's FDB. Then configure the offload to direct the mirrored traffic > to that port, possibly with tagging. > > Signed-off-by: Petr Machata > Signed-off-by: Ido Schimmel > --- > .../net/ethernet/mellanox/mlxsw/spectrum_span.c | 95 ++++++++++++++++++++-- > .../net/ethernet/mellanox/mlxsw/spectrum_span.h | 1 + > 2 files changed, 90 insertions(+), 6 deletions(-) > Looks good, thanks! Reviewed-by: Nikolay Aleksandrov