Netdev List
 help / color / mirror / Atom feed
From: Tariq Toukan <tariqt@nvidia.com>
To: Rishikesh Jethwani <rjethwani@everpuredata.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	Mark Bloch <mbloch@nvidia.com>, Gal Pressman <gal@nvidia.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Boris Pismenny <borisp@nvidia.com>,
	Sabrina Dubroca <sd@queasysnail.net>,
	John Fastabend <john.fastabend@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: Question: net/mlx5e kTLS TX TIS reuse vs in-flight WQEs
Date: Mon, 9 Nov 2026 11:21:28 +0200	[thread overview]
Message-ID: <fa110faa-1947-424b-9197-0c6add014fe9@nvidia.com> (raw)
In-Reply-To: <9a8e3e1a-977a-4e48-ba9a-2b71700f6924@nvidia.com>


On 08/11/2026 21:45, Tariq Toukan wrote:
 > I'm re-running the ConnectX-6 Dx tests with the changes, and will
 > share the RFCs once they pass.

They pass, with one change to the drop below.

 > An skb on another TX queue moves the connection only if no other skb
 > of its socket is in flight

This also dropped on legitimate stack moves: the next skbs, queued
behind the first one on the new TX queue, hold sk_wmem_alloc when it
reaches the driver. So a move that the TX queue selection allows, only
while nothing else of the socket is in flight, now hands over the new
TX queue right there, and the check at xmit is left for skbs that
bypass the selection, like tc skbedit. No drops without forced moves
now.

I'll share my patches shortly.

Thanks,
Tariq

  reply	other threads:[~2026-11-09  9:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 18:17 Question: net/mlx5e kTLS TX TIS reuse vs in-flight WQEs Rishikesh Jethwani
2026-11-03 14:45 ` Tariq Toukan
2026-11-04  5:01   ` Rishikesh Jethwani
2026-11-05  9:25     ` Tariq Toukan
2026-11-06 19:58       ` Rishikesh Jethwani
2026-11-08 19:45         ` Tariq Toukan
2026-11-09  9:21           ` Tariq Toukan [this message]
2026-11-09 23:21           ` Rishikesh Jethwani
2026-11-10 14:45             ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa110faa-1947-424b-9197-0c6add014fe9@nvidia.com \
    --to=tariqt@nvidia.com \
    --cc=borisp@nvidia.com \
    --cc=gal@nvidia.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=rjethwani@everpuredata.com \
    --cc=saeedm@nvidia.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox