From: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH] fjes: Do not load fjes driver if system does not have extended socket device.
Date: Wed, 8 Mar 2017 14:15:21 -0500 [thread overview]
Message-ID: <fa1574c9-9f41-459e-d19b-9db9d9201d64@gmail.com> (raw)
In-Reply-To: <20170307.134440.1909011889217005504.davem@davemloft.net>
Hi David,
On 03/07/2017 04:44 PM, David Miller wrote:
> From: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
> Date: Thu, 2 Mar 2017 11:56:44 -0500
>
>> +
>> /* fjes_init_module - Driver Registration Routine */
>> static int __init fjes_init_module(void)
>> {
>> int result;
>> + bool found = false;
>> +
>
> Please order local variable declarations from longest to shortest
> line.
Thank you for your review.
I'll update it soon.
Thanks,
Yasuaki Ishimatsu
> Thanks.
>
prev parent reply other threads:[~2017-03-08 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:56 [PATCH] fjes: Do not load fjes driver if system does not have extended socket device Yasuaki Ishimatsu
2017-03-07 21:44 ` David Miller
2017-03-08 19:15 ` Yasuaki Ishimatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1574c9-9f41-459e-d19b-9db9d9201d64@gmail.com \
--to=yasu.isimatu@gmail.com \
--cc=davem@davemloft.net \
--cc=izumi.taku@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).