Re: [PATCH net-next 3/3] net: usb: smsc95xx: suspend PHY during USB suspend

[<Parthiban.Veerasooran@microchip.com>]

Hi Oliver,

On 01/04/26 10:54 pm, Oliver Neukum wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
> the content is safe
> 
> Hi,
> 
> On 01.04.26 05:18, Parthiban.Veerasooran@microchip.com wrote:
> 
>> Thank you for pointing it out. I agree with you. I didn’t note it
>> earlier since the issue did not occur during my testing. I will move the
>> phy_suspend() to the appropriate place.
> 
> Thank you.
> 
>>> And, as a question of principle: Why do you suspend the phy
>>> in suspend(), but take no action in resume()?
>>
>> In resume(), I did not call phy_resume() because the resume path already
>> invokes phy_init_hw(), which internally calls
>> phydev->drv->config_init(). This reinitializes and reconfigures the PHY.
> 
> Thank you for the explanation. May I suggest that you add a comment
> to that effect to the driver with your patch? This needs to be pointed
> out. Your code as such is fine. It just needs a comment.

Thank you for the suggestion. I agree and I'll add an explanatory 
comment in the driver and update the patch accordingly.

Best regards,
Parthiban V
> 
>         Regards
>                 Oliver
> 
>