From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EC4C10F14 for ; Wed, 10 Apr 2019 17:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1352A20674 for ; Wed, 10 Apr 2019 17:17:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="cRbl+u9E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729083AbfDJRRV (ORCPT ); Wed, 10 Apr 2019 13:17:21 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35911 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729068AbfDJRRU (ORCPT ); Wed, 10 Apr 2019 13:17:20 -0400 Received: by mail-lj1-f196.google.com with SMTP id r24so2870621ljg.3 for ; Wed, 10 Apr 2019 10:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zIA4EqRynZGMQiq0DYGzBmBLmQmrq//4lfnj7uhflf8=; b=cRbl+u9ES4aVCO9RkkCxuXDslYxPRux5KUQbq5IWScdnJNmq5zG0Ux1P9hqNbfp014 mghrT5Z35/B4PjYrOhKuu9uHhs8iiXxzn8fW0VLS6zlhGTjl1qoZgdlYA8/OccZA1Vfq 3DZa6eqPsNh2C9ZqZtBg9uSfXFMXvP4q9Evbc21IXPAjH5rWMkP3pv4HF62tqkdSoUhr GU2VbfAq20dNe7esmiaTUZxPMndkM85zM/eW4F9dnt36SxHdiVxPTkbR1++XcAmxuWHQ PF+pNx99GtKC6QwH2tLiWGARvkF3dJLeRVaNZmbq/YiWeYuTMaLftCMFm6D/7m+awNzz 2WSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zIA4EqRynZGMQiq0DYGzBmBLmQmrq//4lfnj7uhflf8=; b=gf5Vj/BZQl6hZJY7Xa1XhX2WZJVogzFk2udNpaOwki+2f9Vg64AM2cQGUvsbDNaXSh SswX5fSkQPLAaKjPfBvnSak8iCkyzJYzvq0X1s1Ax8MS6evVz+3XOzhkiuMOds70zA7E eckIANSCRNl7WqzAOoL6OPdvr9EWRbHGcVvzXGNuYmIlfILstFmsB3/UwWWT1vtK8okX J9bLKyUnVdjaXrWyw4iY+ZRWGzU0V/zt3ch+iKD47nHiqJyViZe+YG9YMtsT31hXBZnF BDxUzEAdhwuUoD2ElQbw+r/SLsD2cx6Tm7SR6Qj6Gdskab5BQ+rHRsVpqYWx/5MJ8/2h vgFg== X-Gm-Message-State: APjAAAW/6NwZxFmLFLoAwA6MdBa58AW/bG5gixB/p5op5/bGcljOp7qz 1I/UXWPA0OcXnQ8t1IGRK6p1iw== X-Google-Smtp-Source: APXvYqyx5OtiE+ba1zSDSVrL3o/Oag41N4U34OdgciLsdjTVP8HACrBlx14HIOKlsZ5JhMi/btS+Dw== X-Received: by 2002:a2e:834d:: with SMTP id l13mr24153322ljh.97.1554916638812; Wed, 10 Apr 2019 10:17:18 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.84.172]) by smtp.gmail.com with ESMTPSA id t14sm7247983lji.33.2019.04.10.10.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 10:17:18 -0700 (PDT) Subject: Re: [PATCH v2 net-next] ravb: Avoid unsupported internal delay mode for R-Car E3/D3 To: Andrew Lunn , Simon Horman Cc: David Miller , Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda , Wolfram Sang References: <20190410114502.30362-1-horms+renesas@verge.net.au> <20190410161906.GD8916@lunn.ch> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Wed, 10 Apr 2019 20:17:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190410161906.GD8916@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/10/2019 07:19 PM, Andrew Lunn wrote: >> According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the >> TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 >> (r8a77995). And by extension it is also not supported by RZ/G2E (r9a774c0). >> >> This matches all ES versions of the affected SoCs as it is >> not clear if this problem will be resolved in newer chips. >> This can be revisited, as necessary. >> >> This patch does not error-out if PHY_INTERFACE_MODE_RGMII_ID or >> PHY_INTERFACE_MODE_RGMII_TXID are used on SoCs where TX clock delay >> mode is not supported as there is a risk of introducing a regression >> when used in conjunction with older DT blobs present in the field. > > Hi Simon > > I think it should at least WARN_ON(). Such blobs are broken, even if > they do kind of work. Good idea! Simon, third time's a charm? :-) > Andrew MBR, Sergei