From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Jon Smirl" <jonsmirl@gmail.com>
Cc: "Domen Puncer" <domen@coderock.org>,
netdev@vger.kernel.org, linuxppc-embedded@ozlabs.org
Subject: Re: [RFC PATCH v0.2] net driver: mpc52xx fec
Date: Mon, 3 Sep 2007 10:41:51 -0600 [thread overview]
Message-ID: <fa686aa40709030941x1dee3898ud881497b534cc6aa@mail.gmail.com> (raw)
In-Reply-To: <9e4733910709030909j50710faaw96c95cb369a810b3@mail.gmail.com>
On 9/3/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> On 9/3/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> > On 9/2/07, Domen Puncer <domen@coderock.org> wrote:
> > > Hi!
> > >
> > > new in this version:
> > > - fixed stuff that was commented on.
> > > - added 7-wire support (compile at least, if someone has the hardware,
> > > please test!)
> > > - ethtool support
> >
> > Thanks for this work Domen, comments below...
> >
> > This is a large patch, and it should be broken up into logical
> > changes. ie. split into dts changes, bestcomm changes, fec driver and
> > mdio driver. Easier to review that way. The bestcomm and dts changes
> > don't need to go to the netdev list.
>
> A similar patch that is already broken up is available for Efika.
> http://dev.gentoo.org/~nixnut/efika/efika-patches-2.6.22.tar.bz2
No. That series is Sylvain's full patchset including the old FEC
driver. Domen's patch is a reworked FEC driver, and it only replaces
patch 0008 from that series. However, this patch should be split up
further because it makes changes to both the device tree and the
bestcomm code.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-09-03 16:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 9:51 [RFC PATCH v0.1] net driver: mpc52xx fec Domen Puncer
2007-08-10 13:02 ` Arnaldo Carvalho de Melo
2007-08-13 7:21 ` Domen Puncer
2007-09-02 7:41 ` [RFC PATCH v0.2] " Domen Puncer
2007-09-03 15:57 ` Grant Likely
2007-09-03 16:09 ` Jon Smirl
2007-09-03 16:41 ` Grant Likely [this message]
2007-09-15 12:14 ` Domen Puncer
2007-09-17 9:53 ` Sven Luther
2007-09-17 20:21 ` [PATCH] phy: export phy_mii_ioctl Domen Puncer
2007-09-17 22:08 ` Jon Smirl
2007-09-18 15:16 ` Domen Puncer
2007-09-18 19:17 ` Jon Smirl
2007-09-19 11:56 ` Domen Puncer
2007-09-19 18:44 ` Jon Smirl
2007-09-19 21:18 ` Jon Smirl
2007-09-18 19:29 ` Jon Smirl
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-19 10:37 ` Juergen Beisert
2007-09-19 13:56 ` Jon Smirl
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-20 6:36 ` Jeff Garzik
2007-10-02 12:49 ` [RFC PATCH v0.2] net driver: mpc52xx fec Sascha Hauer
2007-10-02 14:32 ` Domen Puncer
2007-10-02 15:46 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40709030941x1dee3898ud881497b534cc6aa@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=domen@coderock.org \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).