From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [RFC PATCH v0.2] net driver: mpc52xx fec Date: Mon, 3 Sep 2007 10:41:51 -0600 Message-ID: References: <20070810095153.GC13994@moe.telargo.com> <20070902074143.GB2642@nd47.coderock.org> <9e4733910709030909j50710faaw96c95cb369a810b3@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Domen Puncer" , netdev@vger.kernel.org, linuxppc-embedded@ozlabs.org To: "Jon Smirl" Return-path: Received: from an-out-0708.google.com ([209.85.132.251]:19101 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbXICQlw (ORCPT ); Mon, 3 Sep 2007 12:41:52 -0400 Received: by an-out-0708.google.com with SMTP id d31so293647and for ; Mon, 03 Sep 2007 09:41:51 -0700 (PDT) In-Reply-To: <9e4733910709030909j50710faaw96c95cb369a810b3@mail.gmail.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 9/3/07, Jon Smirl wrote: > On 9/3/07, Grant Likely wrote: > > On 9/2/07, Domen Puncer wrote: > > > Hi! > > > > > > new in this version: > > > - fixed stuff that was commented on. > > > - added 7-wire support (compile at least, if someone has the hardware, > > > please test!) > > > - ethtool support > > > > Thanks for this work Domen, comments below... > > > > This is a large patch, and it should be broken up into logical > > changes. ie. split into dts changes, bestcomm changes, fec driver and > > mdio driver. Easier to review that way. The bestcomm and dts changes > > don't need to go to the netdev list. > > A similar patch that is already broken up is available for Efika. > http://dev.gentoo.org/~nixnut/efika/efika-patches-2.6.22.tar.bz2 No. That series is Sylvain's full patchset including the old FEC driver. Domen's patch is a reworked FEC driver, and it only replaces patch 0008 from that series. However, this patch should be split up further because it makes changes to both the device tree and the bestcomm code. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195