From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Grant Likely" Subject: Re: [PATCH] Implement polling for 5200FEC to make netconsole work. Date: Tue, 21 Oct 2008 17:57:03 -0600 Message-ID: References: <20081018214059.1506.28013.stgit@terra> <9e4733910810211641x24f4d76bn5bc614147875d250@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org To: "Jon Smirl" Return-path: Received: from rv-out-0506.google.com ([209.85.198.231]:57705 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbYJUX5F (ORCPT ); Tue, 21 Oct 2008 19:57:05 -0400 Received: by rv-out-0506.google.com with SMTP id k40so2654833rvb.1 for ; Tue, 21 Oct 2008 16:57:04 -0700 (PDT) In-Reply-To: <9e4733910810211641x24f4d76bn5bc614147875d250@mail.gmail.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 21, 2008 at 5:41 PM, Jon Smirl wrote: > Is anyone going to pick this up? I'm looking at it, but I'm not picking it up for .28. It's non-trivial enough that I would have needed to have it before the merge window opened to get it into .28. g. > > On Sat, Oct 18, 2008 at 5:40 PM, Jon Smirl wrote: >> Implement polling for 5200FEC to make netconsole work. Tested on Phytec pcm030 and Efika. >> >> Signed-off-by: Jon Smirl >> --- >> drivers/net/fec_mpc52xx.c | 18 ++++++++++++++++++ >> 1 files changed, 18 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c >> index 4e4f683..aec3b97 100644 >> --- a/drivers/net/fec_mpc52xx.c >> +++ b/drivers/net/fec_mpc52xx.c >> @@ -401,6 +401,21 @@ static int mpc52xx_fec_hard_start_xmit(struct sk_buff *skb, struct net_device *d >> return 0; >> } >> >> +#ifdef CONFIG_NET_POLL_CONTROLLER >> +static void mpc52xx_fec_poll_controller(struct net_device *dev) >> +{ >> + struct mpc52xx_fec_priv *priv = netdev_priv(dev); >> + >> + disable_irq(priv->t_irq); >> + mpc52xx_fec_tx_interrupt(priv->t_irq, dev); >> + enable_irq(priv->t_irq); >> + disable_irq(priv->r_irq); >> + mpc52xx_fec_rx_interrupt(priv->r_irq, dev); >> + enable_irq(priv->r_irq); >> +} >> +#endif >> + >> + >> /* This handles BestComm transmit task interrupts >> */ >> static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) >> @@ -926,6 +941,9 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match) >> ndev->tx_timeout = mpc52xx_fec_tx_timeout; >> ndev->watchdog_timeo = FEC_WATCHDOG_TIMEOUT; >> ndev->base_addr = mem.start; >> +#ifdef CONFIG_NET_POLL_CONTROLLER >> + ndev->poll_controller = mpc52xx_fec_poll_controller; >> +#endif >> >> priv->t_irq = priv->r_irq = ndev->irq = NO_IRQ; /* IRQ are free for now */ >> >> >> > > > > -- > Jon Smirl > jonsmirl@gmail.com > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.