From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error Date: Wed, 14 Oct 2009 13:32:54 -0600 Message-ID: References: <20091014174224.29221.18830.stgit@angua> <4AD62247.4020102@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: John Bonesio , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net To: Wolfgang Grandegger Return-path: In-Reply-To: <4AD62247.4020102@grandegger.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: netdev.vger.kernel.org On Wed, Oct 14, 2009 at 1:11 PM, Wolfgang Grandegger wr= ote: > Grant Likely wrote: >> From: John Bonesio >> >> The MDIO bus cannot be accessed at interrupt context, but on an FEC >> error, the fec_mpc52xx driver reset function also tries to reset the >> PHY. =A0Since the error is detected at IRQ context, and the PHY functions >> try to sleep, the kernel ends up panicking. >> >> Resetting the PHY on an FEC error isn't even necessary. =A0This patch >> solves the problem by removing the PHY reset entirely. > > There is also no need to free and re-allocate the RX buffers in > mpc52xx_fec_reset(). Write and test a patch for me! :-) g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.