From: Grant Likely <grant.likely@secretlab.ca>
To: Liu Yu <yu.liu@freescale.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: Re: [PATCH 1/4] dts/mpc8569mds: Cleanup tbi phy to support rtbi
Date: Mon, 1 Feb 2010 14:46:17 -0700 [thread overview]
Message-ID: <fa686aa41002011346g5e7c6673u93039383f5dd0057@mail.gmail.com> (raw)
In-Reply-To: <1263456799-3306-1-git-send-email-yu.liu@freescale.com>
On Thu, Jan 14, 2010 at 1:13 AM, Liu Yu <yu.liu@freescale.com> wrote:
> After these change, when need to work in rtbi mode,
> just change phy-connection-type to "rtbi".
>
> Also, this work can be done by u-boot.
>
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Looks okay by me,
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts | 47 ++++++++++++++++++++++++++++++---
> 1 files changed, 42 insertions(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
> index 795eb36..8b72eaf 100644
> --- a/arch/powerpc/boot/dts/mpc8569mds.dts
> +++ b/arch/powerpc/boot/dts/mpc8569mds.dts
> @@ -535,6 +535,7 @@
> rx-clock-name = "none";
> tx-clock-name = "clk12";
> pio-handle = <&pio1>;
> + tbi-handle = <&tbi1>;
> phy-handle = <&qe_phy0>;
> phy-connection-type = "rgmii-id";
> };
> @@ -579,7 +580,7 @@
> reg = <0x6>;
> device_type = "ethernet-phy";
> };
> - tbi-phy@11 {
> + tbi1: tbi-phy@11 {
> reg = <0x11>;
> device_type = "tbi-phy";
> };
> @@ -590,7 +591,7 @@
> reg = <0x3520 0x18>;
> compatible = "fsl,ucc-mdio";
>
> - tbi0: tbi-phy@15 {
> + tbi6: tbi-phy@15 {
> reg = <0x15>;
> device_type = "tbi-phy";
> };
> @@ -600,7 +601,7 @@
> #size-cells = <0>;
> reg = <0x3720 0x38>;
> compatible = "fsl,ucc-mdio";
> - tbi1: tbi-phy@17 {
> + tbi8: tbi-phy@17 {
> reg = <0x17>;
> device_type = "tbi-phy";
> };
> @@ -617,10 +618,22 @@
> rx-clock-name = "none";
> tx-clock-name = "clk12";
> pio-handle = <&pio3>;
> + tbi-handle = <&tbi3>;
> phy-handle = <&qe_phy2>;
> phy-connection-type = "rgmii-id";
> };
>
> + mdio@2320 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x2320 0x18>;
> + compatible = "fsl,ucc-mdio";
> + tbi3: tbi-phy@11 {
> + reg = <0x11>;
> + device_type = "tbi-phy";
> + };
> + };
> +
> enet1: ucc@3000 {
> device_type = "network";
> compatible = "ucc_geth";
> @@ -632,10 +645,22 @@
> rx-clock-name = "none";
> tx-clock-name = "clk17";
> pio-handle = <&pio2>;
> + tbi-handle = <&tbi2>;
> phy-handle = <&qe_phy1>;
> phy-connection-type = "rgmii-id";
> };
>
> + mdio@3120 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3120 0x18>;
> + compatible = "fsl,ucc-mdio";
> + tbi2: tbi-phy@11 {
> + reg = <0x11>;
> + device_type = "tbi-phy";
> + };
> + };
> +
> enet3: ucc@3200 {
> device_type = "network";
> compatible = "ucc_geth";
> @@ -647,10 +672,22 @@
> rx-clock-name = "none";
> tx-clock-name = "clk17";
> pio-handle = <&pio4>;
> + tbi-handle = <&tbi4>;
> phy-handle = <&qe_phy3>;
> phy-connection-type = "rgmii-id";
> };
>
> + mdio@3320 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x3320 0x18>;
> + compatible = "fsl,ucc-mdio";
> + tbi4: tbi-phy@11 {
> + reg = <0x11>;
> + device_type = "tbi-phy";
> + };
> + };
> +
> enet5: ucc@3400 {
> device_type = "network";
> compatible = "ucc_geth";
> @@ -661,7 +698,7 @@
> local-mac-address = [ 00 00 00 00 00 00 ];
> rx-clock-name = "none";
> tx-clock-name = "none";
> - tbi-handle = <&tbi0>;
> + tbi-handle = <&tbi6>;
> phy-handle = <&qe_phy5>;
> phy-connection-type = "sgmii";
> };
> @@ -676,7 +713,7 @@
> local-mac-address = [ 00 00 00 00 00 00 ];
> rx-clock-name = "none";
> tx-clock-name = "none";
> - tbi-handle = <&tbi1>;
> + tbi-handle = <&tbi8>;
> phy-handle = <&qe_phy7>;
> phy-connection-type = "sgmii";
> };
> --
> 1.6.4
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2010-02-01 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 8:13 [PATCH 1/4] dts/mpc8569mds: Cleanup tbi phy to support rtbi Liu Yu
2010-01-14 8:13 ` [PATCH 2/4] mpc8569mds: Add bscr setting for rtbi mode Liu Yu
2010-01-14 8:13 ` [PATCH 3/4] ucc_geth: update the tbi-phy setting Liu Yu
2010-01-14 8:13 ` [PATCH 4/4] phy: add RTBI mode for m88e1111 Liu Yu
2010-01-14 16:20 ` Kumar Gala
2010-01-15 2:49 ` Liu Yu-B13201
2010-01-21 9:18 ` David Miller
2010-02-01 22:00 ` [PATCH 3/4] ucc_geth: update the tbi-phy setting Grant Likely
2010-02-01 21:57 ` [PATCH 2/4] mpc8569mds: Add bscr setting for rtbi mode Grant Likely
2010-02-02 5:57 ` Liu Yu-B13201
2010-02-01 21:46 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41002011346g5e7c6673u93039383f5dd0057@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).