From: Grant Likely <grant.likely@secretlab.ca>
To: gfilip@ee.ethz.ch
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] temac: add missing mask
Date: Mon, 22 Feb 2010 15:25:32 -0700 [thread overview]
Message-ID: <fa686aa41002221425p357d7806n85e15f713d1034ec@mail.gmail.com> (raw)
In-Reply-To: <1266865621-28955-5-git-send-email-gfilip@ee.ethz.ch>
On Mon, Feb 22, 2010 at 12:07 PM, <gfilip@ee.ethz.ch> wrote:
> For Virtex4-FX this mask is necessary. I think this is also true for Virtex5. Please test.
>
> Signed-off-by: Filip Gospodinov <gfilip@ee.ethz.ch>
> ---
> drivers/net/ll_temac_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ll_temac_main.c b/drivers/net/ll_temac_main.c
> index 8b4e1b9..43d51b7 100644
> --- a/drivers/net/ll_temac_main.c
> +++ b/drivers/net/ll_temac_main.c
> @@ -627,7 +627,7 @@ static void ll_temac_recv(struct net_device *ndev)
> while ((bdstat & STS_CTRL_APP0_CMPLT)) {
>
> skb = lp->rx_skb[lp->rx_bd_ci];
> - length = cur_p->app4;
> + length = (cur_p->app4 & 0x3fff);
A patch making this change has already been merged into david's next tree.
g.
next prev parent reply other threads:[~2010-02-22 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 19:06 [PATCH 1/5] temac: Add Virtex4 address mappings gfilip
2010-02-22 19:06 ` [PATCH 2/5] temac: dma init for Virtex4 gfilip
2010-02-22 19:06 ` [PATCH 3/5] temac: dma deinit gfilip
2010-02-22 19:07 ` [PATCH 4/5] temac: dma MMIO for Virtex4 gfilip
2010-02-22 19:07 ` [PATCH 5/5] temac: add missing mask gfilip
2010-02-22 22:25 ` Grant Likely [this message]
2010-02-22 22:23 ` [PATCH 2/5] temac: dma init for Virtex4 Grant Likely
2010-02-22 22:10 ` [PATCH 1/5] temac: Add Virtex4 address mappings Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41002221425p357d7806n85e15f713d1034ec@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=gfilip@ee.ethz.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).