From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81112C10F1B for ; Fri, 9 Dec 2022 20:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiLIUWo (ORCPT ); Fri, 9 Dec 2022 15:22:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiLIUWm (ORCPT ); Fri, 9 Dec 2022 15:22:42 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689F9DF2B for ; Fri, 9 Dec 2022 12:22:41 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id j28so464471ila.9 for ; Fri, 09 Dec 2022 12:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/VCJPVUZ229VvXZG5wipT/tFOqRMGUxG79Y/d7XX9HM=; b=Pfmwrwpae+fZaGlILeNFUaIoYSBOcivcDsDgcWEr2kPvYQwhfuFCFOPQHkF1i57cuy ma6SHSiLL5TW//coHBlwCKRfOkI991QkAkeoCPcBgf2ylZZqjv9c13DbIpa80vrm1atb Tq+IoF4nJpJG1ruBIE/4orsDLaYGqpqraP2wWSPSZz+XUpS5eVKaNPj/0Y7IZp6/RAID shwZ9nP8Syw9N90PnyvLq12sYchx635S7YXS/omNUYqYSljx2ItSnNCRObTuEMO/B8xw bhQ4tIIIdM3LWw7Zcodgv8mRr1BZXEt5YD3iDdozoaAjE8lvzL9eJRUcxW361tF/H/lX H11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/VCJPVUZ229VvXZG5wipT/tFOqRMGUxG79Y/d7XX9HM=; b=IxHAwo9aNcfz1F9LbBq44gf8d3Wl9wwl4gFmN5x6pU5gMn88596enZ8GCmmEn5nYZp Yt5qIiA4QRe1upWeTTFRjNgpoyyc23lBugMXpHscMTKHfW3EPAIUG1O9Tssm8RPeSdSP heR3/R50/CW+JuAn5eAQRb0QV0xBk5/qPPOnlPaS6Mq8j87ZAsj1hjdavwtP6JRB5A+T rsxoZe3b9x2sBUzzQsDJIgDeKybvalPdDglY9jsZVV/R2erEMiz8EvVd+i70MfKNTRM+ YUhA7iXUNM4MhCr6zcuQWfykN66VTCdJkbEZfR60o0FkL824t11ntOIEE708E9W/u4vB uXpw== X-Gm-Message-State: ANoB5pksLNEYDj7IAbuvmr3Ea+tPAy+nUZYOzVEgd0UW7CvEqQVc9F0J nsc91O8r90aRpyyH3ZRLyx0PLQ== X-Google-Smtp-Source: AA0mqf4YQB2PfPKgPfJ4UqAF0ol8toR/N7+zMhZkZRuFqZ1iKgHMCBx0XJMb7Nfd8oEJ1vhEM2p2Lg== X-Received: by 2002:a05:6e02:78e:b0:303:52d5:fefe with SMTP id q14-20020a056e02078e00b0030352d5fefemr4012562ils.31.1670617360670; Fri, 09 Dec 2022 12:22:40 -0800 (PST) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id x16-20020a0566380cb000b00389e1142967sm753934jad.57.2022.12.09.12.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 12:22:40 -0800 (PST) Message-ID: Date: Fri, 9 Dec 2022 14:22:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support Content-Language: en-US To: Konrad Dybcio , Alex Elder , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: andersson@kernel.org, agross@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, elder@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss References: <20221208211529.757669-1-elder@linaro.org> <20221208211529.757669-3-elder@linaro.org> <47b2fb29-1c2e-db6e-b14f-6dfe90341825@linaro.org> From: Alex Elder In-Reply-To: <47b2fb29-1c2e-db6e-b14f-6dfe90341825@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/8/22 3:22 PM, Konrad Dybcio wrote: > > > On 8.12.2022 22:15, Alex Elder wrote: >> Add the necessary register and data definitions needed for IPA v4.7, >> which is found on the SM6350 SoC. >> >> Co-developed-by: Luca Weiss >> Signed-off-by: Luca Weiss >> Signed-off-by: Alex Elder >> --- > [...] >> + >> +/* Memory configuration data for an SoC having IPA v4.7 */ >> +static const struct ipa_mem_data ipa_mem_data = { >> + .local_count = ARRAY_SIZE(ipa_mem_local_data), >> + .local = ipa_mem_local_data, >> + .imem_addr = 0x146a9000, >> + .imem_size = 0x00002000, > Should probably be > > 0x146a8000 > 0x00003000 > > with an appropriate change in dt to reserve that region. > > Qualcomm does: > ipa@... { qcom,additional-mapping = <0x146a8000 0x146a8000 0x2000>; }; > > which covers 0x146a8000-0x146a9fff > > plus > > imem@.. { reg = <0x146aa000 0x1000>; }; > > which in total gives us 0x146a8000-0x146aafff Can you tell me where you found this information? > That would also mean all of your writes are kind of skewed, unless > you already applied some offsets to them. This region is used by the modem, but must be set up by the AP. > (IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per > the bootloader memory map) On SM7250 (sorry, I don't know about 7225, or 6350 for that matter), the IMEM starts at 0x14680000 and has length 0x2c000. However that memory is used by multiple entities. The portion set aside for IPA starts at 0x146a9000 and has size 0x2000. -Alex > Konrad