From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95153C10F0E for ; Tue, 9 Apr 2019 15:03:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C7832084F for ; Tue, 9 Apr 2019 15:03:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="0S+gA42y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbfDIPD3 (ORCPT ); Tue, 9 Apr 2019 11:03:29 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42024 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfDIPD2 (ORCPT ); Tue, 9 Apr 2019 11:03:28 -0400 Received: by mail-lj1-f196.google.com with SMTP id v22so14772470lje.9 for ; Tue, 09 Apr 2019 08:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6kWdWsmIMSDl7fmu0OMcFf7UumHlwLsbVs+b9D+JJbc=; b=0S+gA42ybhNFcI/tA+FLyRUGzZYxU/uecpSDDJnt+Xc00AjdL5sYObl5b+2+NISciR LRTUJiEN4LplrAHar4q5Ef5K9EOoee1JRC/BiHXzcs37eQexhIGKoqxgaBTbBTEPRBVP XEuDTs/jBIqy0d1r4jz+A6tJykpiSaHUlw2srXA7eA4HmFeMufGh/9YmQcFI578rDNiJ MGwNqXwN4MimhvnxhZtV+HrzC+QjN6ImPVAhTdxYlJSc67kCwcWWbQRS5EdnkndD4O2t 4SCOcnYh3qtMNO2lhh2Gndhl2PmliRY98YopRHWBCy0lQVAk/cLRgJrXI26AAs2d6nvM X8KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=6kWdWsmIMSDl7fmu0OMcFf7UumHlwLsbVs+b9D+JJbc=; b=DhOCcAzQQy1dtl0vmXJ63BqwEJGsB5RDp9mCQ6eaccdkW3XgFBu7+5RbABJwl1aWFn KOrwpi3IoEqcwKxg+L4XhqlLs9I0jUrjhuUCMV6aryNOIF0Jck73GLYqGgyIHD30yfkz 1vXLPkSyVFUH8EqE9Cs3HWJivsuHr9yxmilL32bMwFcc7t/jq1sXO8aOY33kFSJc+Ftc HuDa0IQmdyQGb7DTxMDCeQG1opAohFPaL0BI0SWMDc1NxpXqXt0dmInzZ5PSnf+OqNgt SKqMVvzYQddFYSmyRpLsQmapUKKobWNrzNu5Po+aRD2jBWCqqo2DtQdJJXgfYiAFqdHa 0cdQ== X-Gm-Message-State: APjAAAVdPbxi72IzSsLWPV3pHKkeytji/6zSSJBvnZwQQ35dcmKErSXp 6/6wXXNk5t/YT5j4LZ4IJ/3aUA== X-Google-Smtp-Source: APXvYqwGObdqukOl+mgcSbXpR7vEMzhCIMlJihfNomDxNjNzGZ3zvCNisiX+RUbgW0hUmKUhkeejjA== X-Received: by 2002:a2e:9619:: with SMTP id v25mr19435117ljh.145.1554822206713; Tue, 09 Apr 2019 08:03:26 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.87.214]) by smtp.gmail.com with ESMTPSA id v13sm6860725lje.84.2019.04.09.08.03.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 08:03:25 -0700 (PDT) Subject: Re: [PATCH/RFC net-next] ravb: Avoid unsupported internal delay mode for R-Car E3/D3 To: Simon Horman , Andrew Lunn Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Magnus Damm , Yoshihiro Shimoda , Wolfram Sang References: <20190408082928.22840-1-horms+renesas@verge.net.au> <12616e19-9127-39db-4346-be642c87b596@cogentembedded.com> <20190408174903.GD15267@lunn.ch> <20190409104523.nunbq6mz5633hx2m@verge.net.au> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Tue, 9 Apr 2019 18:03:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190409104523.nunbq6mz5633hx2m@verge.net.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 04/09/2019 01:45 PM, Simon Horman wrote: >>>> @@ -1979,8 +1985,9 @@ static void ravb_set_delay_mode(struct net_device *ndev) >>>> priv->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID) >>>> set |= APSR_DM_RDM; >>>> >>>> - if (priv->phy_interface == PHY_INTERFACE_MODE_RGMII_ID || >>>> - priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) >>>> + if ((priv->phy_interface == PHY_INTERFACE_MODE_RGMII_ID || >>>> + priv->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) && >>>> + !soc_device_match(ravb_delay_mode_quirk_match)) >>> >>> But don't we need to error out of the probing as we can't set the delay mode >>> requested? >> >> Yes, if we can, we should error out. It just depends on if there are >> broken DT blobs out there. We recently had a lot of pain from broken >> DT blobs using the at803x PHY and getting RGMII modes wrong. In the >> long run, it is best to if DT, but i've no idea how many boards are >> affected. > > Hi Andrew, > > I suspect there are such blobs out there and I'm not sure > what the fall-out may or may not be. You mean the out-of-tree blobs? Because I'm not seeing any in-kernel breakage... MBR, Sergei