From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net 1/2] net: ipv4: update fnhe_pmtu when first hop's MTU
 changes
Date: Mon, 8 Oct 2018 11:18:49 -0600
Message-ID: <fa74dac1-bb8e-7892-a48f-1336eda9628f@gmail.com>
References: <bdb0235df165b1a9684670be3839962c80c9b45a.1539000663.git.sd@queasysnail.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Stefano Brivio <sbrivio@redhat.com>,
        Ido Schimmel <idosch@idosch.org>
To: Sabrina Dubroca <sd@queasysnail.net>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f193.google.com ([209.85.210.193]:46971 "EHLO
        mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726291AbeJIAbf (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 8 Oct 2018 20:31:35 -0400
Received: by mail-pf1-f193.google.com with SMTP id r64-v6so8647927pfb.13
        for <netdev@vger.kernel.org>; Mon, 08 Oct 2018 10:18:53 -0700 (PDT)
In-Reply-To: <bdb0235df165b1a9684670be3839962c80c9b45a.1539000663.git.sd@queasysnail.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 10/8/18 6:36 AM, Sabrina Dubroca wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index c7861e4b402c..dc9d2668d9bb 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2458,6 +2458,13 @@ struct netdev_notifier_info {
>  	struct netlink_ext_ack	*extack;
>  };
>  
> +struct netdev_notifier_info_ext {
> +	struct netdev_notifier_info info; /* must be first */
> +	union {
> +		u32 u32;

I realize you want this to be generic, but that is a really odd
definition. can you make that mtu instead? the union allows other use
cases to add new names.

> +	} ext;
> +};
> +
>  struct netdev_notifier_change_info {
>  	struct netdev_notifier_info info; /* must be first */
>  	unsigned int flags_changed;