netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arinzon, David" <darinzon@amazon.com>
To: "Nelson, Shannon" <shannon.nelson@amd.com>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "Woodhouse, David" <dwmw@amazon.co.uk>,
	"Machulsky, Zorik" <zorik@amazon.com>,
	"Matushevsky, Alexander" <matua@amazon.com>,
	"Bshara, Saeed" <saeedb@amazon.com>,
	"Wilson, Matt" <msw@amazon.com>,
	"Liguori, Anthony" <aliguori@amazon.com>,
	"Bshara, Nafea" <nafea@amazon.com>,
	"Belgazal, Netanel" <netanel@amazon.com>,
	"Saidi, Ali" <alisaidi@amazon.com>,
	"Herrenschmidt, Benjamin" <benh@amazon.com>,
	"Kiyanovski, Arthur" <akiyano@amazon.com>,
	"Dagan, Noam" <ndagan@amazon.com>,
	"Agroskin, Shay" <shayagr@amazon.com>,
	"Itzko, Shahar" <itzko@amazon.com>,
	"Abboud, Osama" <osamaabb@amazon.com>,
	"Ostrovsky, Evgeny" <evostrov@amazon.com>,
	"Tabachnik, Ofir" <ofirt@amazon.com>,
	"Koler, Nati" <nkolder@amazon.com>
Subject: RE: [PATCH v1 net-next 00/11] ENA driver changes
Date: Tue, 30 Jan 2024 09:39:53 +0000	[thread overview]
Message-ID: <fab02eb3391341b3b63c5abf9ff74f47@amazon.com> (raw)
In-Reply-To: <8ff8cd4e-294c-4b1f-8e83-c092132a2445@amd.com>

> On 1/29/2024 12:55 AM, darinzon@amazon.com wrote:
> >
> > From: David Arinzon <darinzon@amazon.com>
> >
> > This patchset contains a set of minor and cosmetic changes to the ENA
> > driver.
> 
> A couple of nits noted, but otherwise looks reasonable.
> 
> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
> 
> 

Thanks for taking the time and reviewing the patchset.
I've addressed some of the comments, while the rest will
be fixed in the next patchset version.

David

> >
> > David Arinzon (11):
> >    net: ena: Remove an unused field
> >    net: ena: Add more documentation for RX copybreak
> >    net: ena: Minor cosmetic changes
> >    net: ena: Enable DIM by default
> >    net: ena: Remove CQ tail pointer update
> >    net: ena: Change error print during ena_device_init()
> >    net: ena: Add more information on TX timeouts
> >    net: ena: Relocate skb_tx_timestamp() to improve time stamping
> >      accuracy
> >    net: ena: Change default print level for netif_ prints
> >    net: ena: handle ena_calc_io_queue_size() possible errors
> >    net: ena: Reduce lines with longer column width boundary
> >
> >   .../device_drivers/ethernet/amazon/ena.rst    |   6 +
> >   drivers/net/ethernet/amazon/ena/ena_com.c     | 323 ++++++------------
> >   drivers/net/ethernet/amazon/ena/ena_com.h     |   6 +-
> >   drivers/net/ethernet/amazon/ena/ena_eth_com.c |  49 ++-
> >   drivers/net/ethernet/amazon/ena/ena_eth_com.h |  39 +--
> >   drivers/net/ethernet/amazon/ena/ena_netdev.c  | 161 ++++++---
> >   .../net/ethernet/amazon/ena/ena_regs_defs.h   |   1 +
> >   drivers/net/ethernet/amazon/ena/ena_xdp.c     |   1 -
> >   8 files changed, 258 insertions(+), 328 deletions(-)
> >
> > --
> > 2.40.1
> >
> >


  reply	other threads:[~2024-01-30  9:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  8:55 [PATCH v1 net-next 00/11] ENA driver changes darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 01/11] net: ena: Remove an unused field darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 02/11] net: ena: Add more documentation for RX copybreak darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 03/11] net: ena: Minor cosmetic changes darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 04/11] net: ena: Enable DIM by default darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 05/11] net: ena: Remove CQ tail pointer update darinzon
2024-01-30  1:16   ` Nelson, Shannon
2024-01-30  9:39     ` Arinzon, David
2024-01-29  8:55 ` [PATCH v1 net-next 06/11] net: ena: Change error print during ena_device_init() darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 07/11] net: ena: Add more information on TX timeouts darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 08/11] net: ena: Relocate skb_tx_timestamp() to improve time stamping accuracy darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 09/11] net: ena: Change default print level for netif_ prints darinzon
2024-01-29  8:55 ` [PATCH v1 net-next 10/11] net: ena: handle ena_calc_io_queue_size() possible errors darinzon
2024-01-30  1:16   ` Nelson, Shannon
2024-01-30  9:39     ` Arinzon, David
2024-01-29  8:55 ` [PATCH v1 net-next 11/11] net: ena: Reduce lines with longer column width boundary darinzon
2024-01-30  1:16   ` Nelson, Shannon
2024-01-30  9:39     ` Arinzon, David
2024-01-30  1:20 ` [PATCH v1 net-next 00/11] ENA driver changes Nelson, Shannon
2024-01-30  9:39   ` Arinzon, David [this message]
2024-01-30 21:07     ` Nelson, Shannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fab02eb3391341b3b63c5abf9ff74f47@amazon.com \
    --to=darinzon@amazon.com \
    --cc=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.co.uk \
    --cc=evostrov@amazon.com \
    --cc=itzko@amazon.com \
    --cc=kuba@kernel.org \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=nkolder@amazon.com \
    --cc=ofirt@amazon.com \
    --cc=osamaabb@amazon.com \
    --cc=saeedb@amazon.com \
    --cc=shannon.nelson@amd.com \
    --cc=shayagr@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).