[PATCH] atm: idt77252: Use sb_pool_remove()

[PATCH] atm: idt77252: Use sb_pool_remove()

[Thomas Fourier]

Replacing the manual pool remove with the dedicated function.

Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
 drivers/atm/idt77252.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index f2e91b7d79f0..888695ccc2a7 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -1844,7 +1844,6 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 {
 	struct sk_buff *skb;
 	dma_addr_t paddr;
-	u32 handle;
 
 	while (count--) {
 		skb = dev_alloc_skb(size);
@@ -1876,8 +1875,7 @@ add_rx_skb(struct idt77252_dev *card, int queue,
 			 skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE);
 
 outpoolrm:
-	handle = IDT77252_PRV_POOL(skb);
-	card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL;
+	sb_pool_remove(card, skb);
 
 outfree:
 	dev_kfree_skb(skb);
-- 
2.43.0

Re: [PATCH] atm: idt77252: Use sb_pool_remove()

[Simon Horman]

On Thu, Jun 26, 2025 at 09:53:16AM +0200, Thomas Fourier wrote:
> Replacing the manual pool remove with the dedicated function.
> 
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>

Hi Thomas,

Unfortunately this patch doesn't apply cleanly on net-next,
which is a pre-requisite for our CI to process it.

I suggest reposting this patch once your other patch to this file [1]
has been accepted.

[1] [PATCH v2] atm: idt77252: Add missing `dma_map_error()`
    https://lore.kernel.org/all/20250624064148.12815-3-fourier.thomas@gmail.com/

The code change itself looks good to me.

-- 
pw-bot: deferred

Re: [PATCH] atm: idt77252: Use sb_pool_remove()

[Thomas Fourier]

On 26/06/2025 13:06, Simon Horman wrote:
> On Thu, Jun 26, 2025 at 09:53:16AM +0200, Thomas Fourier wrote:
>> Replacing the manual pool remove with the dedicated function.
>>
>> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> Hi Thomas,
>
> Unfortunately this patch doesn't apply cleanly on net-next,
> which is a pre-requisite for our CI to process it.
>
> I suggest reposting this patch once your other patch to this file [1]
> has been accepted.
Hi Simon,

My bad, I thought it was applied but I guess it was on net, not net-next.

>
> [1] [PATCH v2] atm: idt77252: Add missing `dma_map_error()`
>      https://lore.kernel.org/all/20250624064148.12815-3-fourier.thomas@gmail.com/
>
> The code change itself looks good to me.
>
Thanks for the review!