From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>, Po Liu <po.liu@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Michael Walle <michael@walle.cc>, Rui Sousa <rui.sousa@nxp.com>,
Yangbo Lu <yangbo.lu@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 net 10/10] net: dsa: felix: break at first CPU port during init and teardown
Date: Tue, 12 Oct 2021 14:31:03 -0700 [thread overview]
Message-ID: <faca12ef-e367-4a40-04b0-67f37f9c49fd@gmail.com> (raw)
In-Reply-To: <20211012114044.2526146-11-vladimir.oltean@nxp.com>
On 10/12/21 4:40 AM, Vladimir Oltean wrote:
> The NXP LS1028A switch has two Ethernet ports towards the CPU, but only
> one of them is capable of acting as an NPI port at a time (inject and
> extract packets using DSA tags).
>
> However, using the alternative ocelot-8021q tagging protocol, it should
> be possible to use both CPU ports symmetrically, but for that we need to
> mark both ports in the device tree as DSA masters.
>
> In the process of doing that, it can be seen that traffic to/from the
> network stack gets broken, and this is because the Felix driver iterates
> through all DSA CPU ports and configures them as NPI ports. But since
> there can only be a single NPI port, we effectively end up in a
> situation where DSA thinks the default CPU port is the first one, but
> the hardware port configured to be an NPI is the last one.
>
> I would like to treat this as a bug, because if the updated device trees
> are going to start circulating, it would be really good for existing
> kernels to support them, too.
>
> Fixes: adb3dccf090b ("net: dsa: felix: convert to the new .change_tag_protocol DSA API")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-10-12 21:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:40 [PATCH v2 net 00/10] Felix DSA driver fixes Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 01/10] net: mscc: ocelot: make use of all 63 PTP timestamp identifiers Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 02/10] net: mscc: ocelot: avoid overflowing the PTP timestamp FIFO Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 03/10] net: mscc: ocelot: warn when a PTP IRQ is raised for an unknown skb Vladimir Oltean
2021-10-12 21:41 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 04/10] net: mscc: ocelot: deny TX timestamping of non-PTP packets Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 05/10] net: mscc: ocelot: cross-check the sequence id from the timestamp FIFO with the skb PTP header Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 06/10] net: dsa: tag_ocelot: break circular dependency with ocelot switch lib driver Vladimir Oltean
2021-10-12 21:32 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 07/10] net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch lib Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 08/10] net: dsa: felix: purge skb from TX timestamping queue if it cannot be sent Vladimir Oltean
2021-10-12 11:40 ` [PATCH v2 net 09/10] net: dsa: tag_ocelot_8021q: fix inability to inject STP BPDUs into BLOCKING ports Vladimir Oltean
2021-10-12 21:42 ` Florian Fainelli
2021-10-12 11:40 ` [PATCH v2 net 10/10] net: dsa: felix: break at first CPU port during init and teardown Vladimir Oltean
2021-10-12 21:31 ` Florian Fainelli [this message]
2021-10-13 2:40 ` [PATCH v2 net 00/10] Felix DSA driver fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faca12ef-e367-4a40-04b0-67f37f9c49fd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=po.liu@nxp.com \
--cc=rui.sousa@nxp.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).