From: Julian Anastasov <ja@ssi.bg>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Axel Mierczuk <axel.mierczuk@1password.com>,
Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
Willy Tarreau <w@1wt.eu>,
Keith Hoodlet <keith.hoodlet@1password.com>
Subject: Re: [PATCH nf 0/2] ipvs: fix OOB write when NATing ICMPv6 errors quoting non-first fragments
Date: Wed, 30 Sep 2026 20:34:57 +0300 (EEST) [thread overview]
Message-ID: <faecbb5a-01bc-ccc3-95e1-03579ba98a4e@ssi.bg> (raw)
In-Reply-To: <20260928111538.GA389451@shredder>
Hello,
On Mon, 28 Sep 2026, Ido Schimmel wrote:
> On Fri, Sep 25, 2026 at 08:50:58PM +0300, Julian Anastasov wrote:
> >
> > > Axel Mierczuk (2):
> > > ipvs: avoid out-of-bounds write in ip_vs_nat_icmp_v6
> > > ipv6: update *offset for non-first fragments in ipv6_find_hdr()
> > >
> > > net/ipv6/exthdrs_core.c | 6 +++++-
> > > net/netfilter/ipvs/ip_vs_core.c | 14 ++++++++++++++
> > > 2 files changed, 19 insertions(+), 1 deletion(-)
> >
> > Both patches look good to me, thanks!
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> > The ipv6 patch needs review from the net team and
> > may need some Fixes line:
> >
> > Fixes: b777e0ce7437 ("[NETFILTER]: make ipv6_find_hdr() find transport protocol header")
>
> Doesn't patch 2 make patch 1 redundant? It seems that the comments added
> by patch 1 become stale with patch 2, no?
>
> If so, why do we need both? Why not send only patch 2 and blame
> 63dca2c0b0e7a?
The idea was to have IPVS fix that can be backported
alone, if needed.
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2026-09-30 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 14:11 [PATCH nf 0/2] ipvs: fix OOB write when NATing ICMPv6 errors quoting non-first fragments Axel Mierczuk
2026-09-25 14:11 ` [PATCH nf 1/2] ipvs: avoid out-of-bounds write in ip_vs_nat_icmp_v6 Axel Mierczuk
2026-09-29 15:57 ` netdev-bot+sashiko
2026-09-25 14:11 ` [PATCH nf 2/2] ipv6: update *offset for non-first fragments in ipv6_find_hdr() Axel Mierczuk
2026-09-29 15:57 ` netdev-bot+sashiko
2026-09-25 17:50 ` [PATCH nf 0/2] ipvs: fix OOB write when NATing ICMPv6 errors quoting non-first fragments Julian Anastasov
2026-09-28 11:15 ` Ido Schimmel
2026-09-30 17:34 ` Julian Anastasov [this message]
2026-10-01 16:10 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faecbb5a-01bc-ccc3-95e1-03579ba98a4e@ssi.bg \
--to=ja@ssi.bg \
--cc=axel.mierczuk@1password.com \
--cc=coreteam@netfilter.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=idosch@nvidia.com \
--cc=keith.hoodlet@1password.com \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox