From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tipi-net.de (mail.tipi-net.de [194.13.80.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70F638C43E; Mon, 6 Apr 2026 18:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.13.80.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775500192; cv=none; b=rDnwYusS2fKXVFgVE+dA14QcHR77fFYpW4w1aOuj800VaOrxaCSW6d8SmgrTNn1b9nlIX0dYrc9fF4DzSMSjJEZ11c+pG9qxJGUmv0FIYh3JaN8FUA4An16Hs++2nQOWls3JZCM81acCCLNM8lRoZMbWwaHwwCTgHFuDLufP08o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775500192; c=relaxed/simple; bh=1FsQQzvn0jCYwDQ9OY5NDoR1XnzzljGSEivuWJI4ugU=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=OpKKRJXc8qVrCTCrmwWK4Df4LdDLFURHz/+rue8j2VxwpLOOfnbrhoIsNNOpJz65z8xRyKoRVPcV3eOvXJmSIgFcIosXdDyO0gzTeXxyxXthjvYJBUAXZIMekk51N4AXTOOjwFAFjK34t3SNj1zv70Kg7bU0uWyUnH3e04P0rMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de; spf=pass smtp.mailfrom=tipi-net.de; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b=t5AhVQcJ; arc=none smtp.client-ip=194.13.80.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b="t5AhVQcJ" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0FBFEA5889; Mon, 6 Apr 2026 20:29:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tipi-net.de; s=dkim; t=1775500182; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=XNAoPmqAN02jd6z5OC5FpXvslNmeUiMwHsaPe5dtZN8=; b=t5AhVQcJVQ8fcHQPcrrBrsh4JueYmSr3+2xeu17RLAdmhPa+Nekzpz4exBm+LLzj+PqO3I o8jL8FBK+2OTerm4m5lp8T8mofenjfM1vqrsx9k7ga25/wRl3tDut31z9x1VLS4ItP7wa0 7EP+UcCw4/OpgxSUCwVNuiAgN3tLXhQr8pyh4dp23kHzo64Da+UWOFVdmwcStwsXH5fKPa 2buoNs0sv5UMJjex7uFt8MU/vfIIxrmaqO3hXXA6jJcmZmCC/o5Eguung3U8bvb8fblFF/ Hg9odyxPfcPqUNvtgcWXMabr6CBRyjYTbIPxLqlF9NP0XjLa3xDDmA0rokUj0A== Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 06 Apr 2026 20:29:38 +0200 From: Nicolai Buchwitz To: "Russell King (Oracle)" Cc: Florian Fainelli , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/3] net: phy: add support for disabling autonomous EEE In-Reply-To: References: <20260406-devel-autonomous-eee-v1-0-b335e7143711@tipi-net.de> <9272c5dd653039b3def8caaea3e631c5@tipi-net.de> <5298959c-12de-4992-a896-3d1371cba111@lunn.ch> Message-ID: X-Sender: nb@tipi-net.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 6.4.2026 19:10, Russell King (Oracle) wrote: > On Mon, Apr 06, 2026 at 09:43:55AM -0700, Florian Fainelli wrote: >> That is almost a guarantee given, there will be a broken MAC > > Well, it already exists. modern i.MX platforms use stmmac, and some > bright spark wired lpi_intr_o together with the main stmmac interrupt > which causes interrupt storms when the receive path exits LPI. This > makes stmmac LPI unusable on this platform. > > So, if i.MX is paired with a PHY that can do its own EEE, then we > have this exact scenaro. For DT-based platforms (like the broken i.MX), this could be addressed similar to what we already have with eee-broken-* properties. For platforms without DT it's getting more complicated and I can't see a way without ethtool. Maybe we need something similar to ethtool --set-hwtimestamp-cfg and make the EEE provider selectable at runtime? Something like ethtool --set-eee eth0 mode mac|phy. I have the feeling we will need this sooner rather than later, given the overall quality of EEE implementations out there... Nicolai