From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net-next v4 00/11] Modify action API for implementing
 lockless actions
Date: Fri, 1 Jun 2018 08:24:16 -0400
Message-ID: <fb06526a-8fe6-1b57-cffe-8ae184ad80f4@mojatatu.com>
References: <1527753499-32124-1-git-send-email-vladbu@mellanox.com>
 <262fbd11-401e-90cf-4226-39b1604eb16d@mojatatu.com>
 <vbfmuwgf19e.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org,
        kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org,
        daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org,
        marcelo.leitner@gmail.com, kliteyn@mellanox.com
To: Vlad Buslov <vladbu@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f179.google.com ([209.85.216.179]:37764 "EHLO
        mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751813AbeFAMYT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 1 Jun 2018 08:24:19 -0400
Received: by mail-qt0-f179.google.com with SMTP id q13-v6so31875498qtp.4
        for <netdev@vger.kernel.org>; Fri, 01 Jun 2018 05:24:19 -0700 (PDT)
In-Reply-To: <vbfmuwgf19e.fsf@reg-r-vrt-018-180.mtr.labs.mlnx>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 31/05/18 08:38 AM, Vlad Buslov wrote:

> Hi Jamal,
> 
> On current net-next I still have action with single reference after last
> step:
> ~$ sudo $TC -s actions ls action skbedit
> total acts 1
>                                                                 
>          action order 0:  skbedit mark 1 pipe
>           index 1 ref 2 bind 1 installed 47 sec used 47 sec
>          Action statistics:
>          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>          backlog 0b 0p requeues 0
> ~$ sudo $TC filter del dev lo parent ffff: protocol ip prio 1 \
>> u32 match ip dst 127.0.0.1/32 flowid 1:1
> ~$ sudo $TC -s actions ls action skbedit
> total acts 1
>                                                                 
>          action order 0:  skbedit mark 1 pipe
>           index 1 ref 1 bind 0 installed 80 sec used 80 sec
>          Action statistics:
>          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>          backlog 0b 0p requeues 0
> 
> Which branch are you testing on?

You are correct - this is how it works now (I was thinking of a
very old version before Cong made some changes a while back).
Just vet this continues to work as above.

cheers,
jamal