From: Andrew Lunn <andrew@lunn.ch>
To: "Alvaro (Al-vuh-roe) Reyes" <a-reyes1@ti.com>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, maxime.chevallier@bootlin.com,
o.rempel@pengutronix.de, spatton@ti.com, r-kommineni@ti.com,
e-mayhew@ti.com, praneeth@ti.com, p-varis@ti.com, d-qiu@ti.com
Subject: Re: [PATCH 2/5] net: phy: dp83tg720: Added SGMII Support
Date: Thu, 19 Sep 2024 23:12:41 +0200 [thread overview]
Message-ID: <fb07f305-e01b-455f-9568-8a62d54b63e2@lunn.ch> (raw)
In-Reply-To: <dcb62e7332fae6ca41e55a7698a7011adada6d86.1726263095.git.a-reyes1@ti.com>
> +#define MMD1F 0x1f
> +#define MMD1 0x1
MDIO_MMD_VEND2 and MDIO_MMD_PMAPMD. But i don't think MMD1 is used?
> +
> /* MDIO_MMD_VEND2 registers */
> #define DP83TG720_MII_REG_10 0x10
> #define DP83TG720_STS_MII_INT BIT(7)
> @@ -69,6 +72,13 @@
It looks like the SGMII register goes here, since it is in
MDIO_MMD_VEND2.
Andrew
next prev parent reply other threads:[~2024-09-19 21:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 21:01 [PATCH 0/5] Extending features on DP83TG720 driver Alvaro (Al-vuh-roe) Reyes
2024-09-19 21:01 ` [PATCH 1/5] net: phy: dp83tg720: Changed Macro names Alvaro (Al-vuh-roe) Reyes
2024-09-23 6:56 ` Oleksij Rempel
2024-09-19 21:01 ` [PATCH 2/5] net: phy: dp83tg720: Added SGMII Support Alvaro (Al-vuh-roe) Reyes
2024-09-19 21:12 ` Andrew Lunn [this message]
2024-09-19 21:01 ` [PATCH 3/5] net: phy: dp83tg720: Extending support to DP83TG721 PHY Alvaro (Al-vuh-roe) Reyes
2024-09-19 21:26 ` Andrew Lunn
2024-09-23 6:42 ` Oleksij Rempel
2024-09-19 21:01 ` [PATCH 4/5] net: phy: dp83tg720: Added OA script Alvaro (Al-vuh-roe) Reyes
2024-09-19 21:44 ` Andrew Lunn
2024-09-23 5:22 ` Oleksij Rempel
2024-09-19 21:01 ` [PATCH 5/5] net: phy: dp83tg720: fixed Linux coding standards issues Alvaro (Al-vuh-roe) Reyes
2024-09-19 21:47 ` Andrew Lunn
2024-09-20 11:26 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb07f305-e01b-455f-9568-8a62d54b63e2@lunn.ch \
--to=andrew@lunn.ch \
--cc=a-reyes1@ti.com \
--cc=d-qiu@ti.com \
--cc=e-mayhew@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=p-varis@ti.com \
--cc=praneeth@ti.com \
--cc=r-kommineni@ti.com \
--cc=spatton@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).