netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>,
	corbet@lwn.net, davem@davemloft.net, edumazet@google.com,
	horms@kernel.org, kuba@kernel.org
Cc: linux-doc@vger.kernel.org, linux-kernel-mentees@lists.linux.dev,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	skhan@linuxfoundation.com, jacob.e.keller@intel.com,
	alok.a.tiwari@oracle.com, bagasdotme@gmail.com
Subject: Re: [PATCH net-next v5] docs: net: sysctl documentation cleanup
Date: Tue, 24 Jun 2025 14:53:55 +0200	[thread overview]
Message-ID: <fb0f1e3c-2229-4860-b46a-b99f6dbfdfe6@redhat.com> (raw)
In-Reply-To: <20250622090720.190673-1-abdelrahmanfekry375@gmail.com>

On 6/22/25 11:07 AM, Abdelrahman Fekry wrote:
> @@ -593,10 +629,16 @@ tcp_min_rtt_wlen - INTEGER
>  	Default: 300
>  
>  tcp_moderate_rcvbuf - BOOLEAN
> -	If set, TCP performs receive buffer auto-tuning, attempting to
> +	If enabled, TCP performs receive buffer auto-tuning, attempting to
>  	automatically size the buffer (no greater than tcp_rmem[2]) to
> -	match the size required by the path for full throughput.  Enabled by
> -	default.
> +	match the size required by the path for full throughput.
> +
> +	Possible values:
> +
> +	- 0 (disabled)
> +	- 1 (enabled)
> +
> +	Default: 0 (disabled)

This uncorrectly changes the default value: should be 1.

>  icmp_echo_ignore_broadcasts - BOOLEAN
> -	If set non-zero, then the kernel will ignore all ICMP ECHO and
> +	If enabled, then the kernel will ignore all ICMP ECHO and
>  	TIMESTAMP requests sent to it via broadcast/multicast.
>  
> -	Default: 1
> +	Possible values:
> +
> +	- 0 (disabled)
> +	- 1 (enabled)
> +
> +	Default: 0 (disabled)

Same here.

/P


  parent reply	other threads:[~2025-06-24 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22  9:07 [PATCH net-next v5] docs: net: sysctl documentation cleanup Abdelrahman Fekry
2025-06-22  9:49 ` Bagas Sanjaya
2025-06-24 12:53 ` Paolo Abeni [this message]
2025-06-24 12:59   ` Abdelrahman Fekry
  -- strict thread matches above, loose matches on Subject: below --
2025-06-22  9:05 Abdelrahman Fekry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb0f1e3c-2229-4860-b46a-b99f6dbfdfe6@redhat.com \
    --to=pabeni@redhat.com \
    --cc=abdelrahmanfekry375@gmail.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).