From: Daniel Borkmann <daniel@iogearbox.net>
To: Song Liu <songliubraving@fb.com>, netdev@vger.kernel.org
Cc: kernel-team@fb.com, Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH bpf] xdp: linearize skb in netif_receive_generic_xdp()
Date: Fri, 15 Dec 2017 14:39:02 +0100 [thread overview]
Message-ID: <fb684031-b0d0-06cb-ac1b-64d3aec44bfb@iogearbox.net> (raw)
In-Reply-To: <20171215011756.573758-1-songliubraving@fb.com>
On 12/15/2017 02:17 AM, Song Liu wrote:
> In netif_receive_generic_xdp(), it is necessary to linearize all
> nonlinear skb. However, in current implementation, skb with
> troom <= 0 are not linearized. This patch fixes this by calling
> skb_linearize() for all nonlinear skb.
>
> Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access")
> Signed-off-by: Song Liu <songliubraving@fb.com>
> Acked-by: Martin KaFai Lau <kafai@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
Agree, applied to bpf, thanks Song!
prev parent reply other threads:[~2017-12-15 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 1:17 [PATCH bpf] xdp: linearize skb in netif_receive_generic_xdp() Song Liu
2017-12-15 13:39 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb684031-b0d0-06cb-ac1b-64d3aec44bfb@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox