Re: [PATCH v2 net-next] net: display hw address of source machine during ipv6 DAD failure

[David Ahern <dsahern@gmail.com>]

On 10/30/17 5:38 PM, Vishwanath Pai wrote:
> This patch updates the error messages displayed in kernel log to include
> hwaddress of the source machine that caused ipv6 duplicate address
> detection failures.
> 
> Examples:
> 
> a) When we receive a NA packet from another machine advertising our
> address:
> 
> ICMPv6: NA: 34:ab:cd:56:11:e8 advertised our address 2001:db8:: on eth0!
> 
> b) When we detect DAD failure during address assignment to an interface:
> 
> IPv6: eth0: IPv6 duplicate address 2001:db8:: used by 34:ab:cd:56:11:e8
> detected!
> 
> v2:
>     Changed %pI6 to %pI6c in ndisc_recv_na()
>     Chaged the v6 address in the commit message to 2001:db8::
> 
> Suggested-by: Igor Lubashev <ilubashe@akamai.com>
> Signed-off-by: Vishwanath Pai <vpai@akamai.com>
> ---
>  include/net/addrconf.h | 2 +-
>  net/ipv6/addrconf.c    | 6 +++---
>  net/ipv6/ndisc.c       | 9 +++++----
>  3 files changed, 9 insertions(+), 8 deletions(-)

LGTM

Acked-by: David Ahern <dsahern@gmail.com>