From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net-next] modules: allow modprobe load regular elf binaries Date: Thu, 22 Mar 2018 15:21:33 -0700 Message-ID: References: <20180309.135724.452219538059491199.davem@davemloft.net> <81b7599d-aab7-6cb6-7843-64510c8f6260@fb.com> <20180310140843.GP4449@wotan.suse.de> <20180310151652.GV4449@wotan.suse.de> <20180322205413.GA30543@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Jessica Yu , Linus Torvalds , Mimi Zohar , Djalal Harouni , David Miller , Kees Cook , Alexei Starovoitov , Al Viro , Daniel Borkmann , Greg Kroah-Hartman , Network Development , Linux Kernel Mailing List , kernel-team , Linux API , Michal Hocko , Hannes Reinecke , To: Andy Lutomirski , "Luis R. Rodriguez" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 3/22/18 3:15 PM, Andy Lutomirski wrote: > On Thu, Mar 22, 2018 at 8:54 PM, Luis R. Rodriguez wrote: >> If we can ensure that these usermode modules don't take *any time at all* on >> their init *from the start*, it would be wonderful and we'd end up avoiding >> some really odd corner case issues later. >> > > I don't see why this issue needs to exist at all for the new stuff. > After all, the new things aren't usermode modules per se. They're > regular kernel code (modular or otherwise) that loads a usermode > helper. All we need to do is to make sure that, if this is > distributed as a module, that it's init routine doesn't wait for a > long time, right? I've implemented all of the previous suggestions and now there are zero changes to kernel/module.c I still need to finish tracpoint stuff first and polish umh code a bit before sending new version. Let's hold on this thread until then.