From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B369C43381 for ; Sun, 31 Mar 2019 17:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBCE72082C for ; Sun, 31 Mar 2019 17:54:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kZ08/06j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731317AbfCaRyZ (ORCPT ); Sun, 31 Mar 2019 13:54:25 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45561 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731228AbfCaRyY (ORCPT ); Sun, 31 Mar 2019 13:54:24 -0400 Received: by mail-wr1-f65.google.com with SMTP id s15so8879994wra.12 for ; Sun, 31 Mar 2019 10:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fRv1OhxJ3EOS0m92UtoBvxP8KZtxauamaoxMwH2TjNc=; b=kZ08/06jYfd+CMp27KaT7YBLmg59tLT3omODDpbgMKQx95XAIkQlJc4BmTuIG0xEo2 QYPIt3mVURSPOMy9hpHQAOnCPgzsAu0wshXXa8J6c9TNfTp7l7cM/xBmx33g0bWcmPln 5hA8dufxD067wZb5Mp/2gFTYI4avCI8/v6fqnGZuz2feAGRVjzsNEUtfQpZFdgd5tQ9S mq+iPFnukBqV61UqlOYKWcP0f924hoKlJgQoqiHfoETWmoVrTzx26Y4/bMFWTo3Ywg4V xZ7BQxeU8/pTBGqgYXlQBN3T+DZG03nQaMCXU0HcSHQGsWnAzcEOs4Jy4sDkIfpq3niG 0UPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fRv1OhxJ3EOS0m92UtoBvxP8KZtxauamaoxMwH2TjNc=; b=cysVJ/Kp2yqm6UTJGBPZFSA+kijozuRnfbs/sTbO3KU7X4cN9iZ95F/tEFASj6p0gA X7uJeqgs4zzsuxCulhS1NhJuGc/ZOKnChEc2FMkeACD4gsg7WaGJ/RPgYAfE2EL3j+ng OzPelw/AMnO2l5Sbog8Y2ejn9FZmjf63KmZicnVEeC3jxyXVHBBdN4FoYaaC1iiuODWU fwSfRU/DhZ/JLAFwiE1B231JjhF22tRBbg6H9cWQO36DwUvUGv4reGoZdeEyHe6mYuy6 cTp2Wy6HAHSD91xWV6rcDOqjg/Ylyy1yR2XggvekUQFPCtCyXoqg7N0c5xMqZaWR9Q3D cPiA== X-Gm-Message-State: APjAAAWi+XGUiHyirVGztsFHY4QMNLy2w2ZQ5OXTMqmrdNkJbIPq5tZG 6HM06QlbGxaOCt8U2Qo49K/JPq1g X-Google-Smtp-Source: APXvYqyNL7EwS6DvzeLUWJZdKP2m/clriPo6x8HzQQBYt5STq3iAHyATF4DoJz49q99yCd6fwnV8dQ== X-Received: by 2002:adf:ed8f:: with SMTP id c15mr38855066wro.144.1554054862816; Sun, 31 Mar 2019 10:54:22 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:a4e7:3af3:db88:50bb? (p200300EA8BE1DD00A4E73AF3DB8850BB.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:a4e7:3af3:db88:50bb]) by smtp.googlemail.com with ESMTPSA id j3sm20154840wre.51.2019.03.31.10.54.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 10:54:22 -0700 (PDT) Subject: [PATCH net-next 2/2] net: phy: deal properly with autoneg incomplete in genphy_c45_read_lpa From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: Message-ID: Date: Sun, 31 Mar 2019 19:54:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The link partner advertisement registers are not guaranteed to contain valid values if autoneg is incomplete. Therefore, if MDIO_AN_STAT1_COMPLETE isn't set, let's clear all link partner capability bits. This also avoids unnecessary register reads if link is down and phylib is in polling mode. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy-c45.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 666fbb0ee..05c3e87ff 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -266,6 +266,17 @@ int genphy_c45_read_lpa(struct phy_device *phydev) if (val < 0) return val; + if (!(val & MDIO_AN_STAT1_COMPLETE)) { + linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, + phydev->lp_advertising); + mii_10gbt_stat_mod_linkmode_lpa_t(phydev->lp_advertising, 0); + mii_adv_mod_linkmode_adv_t(phydev->lp_advertising, 0); + phydev->pause = 0; + phydev->asym_pause = 0; + + return 0; + } + linkmode_mod_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->lp_advertising, val & MDIO_AN_STAT1_LPABLE); -- 2.21.0