From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DB9C4167B for ; Fri, 25 Nov 2022 12:11:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiKYMLA (ORCPT ); Fri, 25 Nov 2022 07:11:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKYMK7 (ORCPT ); Fri, 25 Nov 2022 07:10:59 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D9F7421AC for ; Fri, 25 Nov 2022 04:10:58 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id a29so6595618lfj.9 for ; Fri, 25 Nov 2022 04:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FwheS7W3PJSUlRY8b47wc0KETioQqU6W+QumFAOe5GA=; b=Ie4PK9vVTrfbphdAEVAsnpNCCVym61AlASjuuKkW3Airp2tY5blaHGxlNXSh9vrMs4 SL3Ei4Kd7oEwHXIBW7eCV6ojFK4QoAq1BryS07BKqcjxb8Rq9tvW5Xo3r9QyMDF9tEJR H4XgGtewIWdY4AXNJ7Kxunfv3U1xWSZxnwbSlNKWVwbHPS6vAj4YV6tfrXJ2ndfkjRQg CFEcUY61ni9v3BwNcBOUPYklByQ7CpkD2jx09+MrD9GsW+je4D0MLJM7nM6vTgvX+/Lt TGs8sDsi+W2zKCRJgn0RmC9HZInzq0gjEKBSkhdr/kwNId44yIkVn4Eos3WFaOjino6B C3EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FwheS7W3PJSUlRY8b47wc0KETioQqU6W+QumFAOe5GA=; b=stn5ekd1XW48jWEIgX/RO2ZuZ6muAtcfX33+ozPrNgq/ebEEXHb17Pse6rLshvKcYr uQcV8eWRpwAmkscTPUOS4mx8PXD94aiJEfBv61wc6CLckodq5bVeIEcdVghqFO6uMnvA WnR1ipO4q1j+cbsyMmipuEZNmTw+ExazPVRvLxZ7J+auDUw12r3x+qVkhedAdTqYfXns Nfu4B1qTgVm3WmsGojhtASLQXAYhJ+Z60G+MsrA3jn9Qb+qRD4exEwKGk6y8KJFC3Ahd nS3fkXHKwpPpeQelqivWB9MrACt8IaS5KMBbrKNLTSs9Px13jnZEn2Zp63cjQzWvQpAO fYjw== X-Gm-Message-State: ANoB5pmazcwehwiHB14p0UHVWcpF+VzIZrAjBgQoT0aAgb3Sipc/KD0C nWtgFSCAhZE8cmtrAj6yzRAAMw== X-Google-Smtp-Source: AA0mqf68tOvuTcSzyAPy6oW4Sx+ZczsMO12qtp1bc9Pp+m0Ch6uGXznDzBePxRQy+8SCkSWGbeTijg== X-Received: by 2002:a05:6512:1184:b0:4af:a588:e8bd with SMTP id g4-20020a056512118400b004afa588e8bdmr12064931lfr.173.1669378256311; Fri, 25 Nov 2022 04:10:56 -0800 (PST) Received: from [192.168.1.101] (95.49.32.48.neoplus.adsl.tpnet.pl. [95.49.32.48]) by smtp.gmail.com with ESMTPSA id b23-20020ac247f7000000b004aa95889063sm509219lfp.43.2022.11.25.04.10.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 04:10:55 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 13:10:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi Content-Language: en-US To: Kalle Valo Cc: Linus Walleij , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , Hector Martin , "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "martin.botka@somainline.org" , "angelogioacchino.delregno@somainline.org" , "marijn.suijten@somainline.org" , "jamipkettunen@somainline.org" , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , "Zhao, Jiaqing" , "Russell King (Oracle)" , Soon Tak Lee , "linux-wireless@vger.kernel.org" , "brcm80211-dev-list.pdl@broadcom.com" , "SHA-cyfmac-dev-list@infineon.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> <0e65a8b2-0827-af1e-602c-76d9450e3d11@marcan.st> <7fd077c5-83f8-02e2-03c1-900a47f05dc1@somainline.org> <20220922133056.eo26da4npkg6bpf2@bang-olufsen.dk> <87sfke32pc.fsf@kernel.org> <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> <87fse76yig.fsf@kernel.org> From: Konrad Dybcio In-Reply-To: <87fse76yig.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 25.11.2022 12:53, Kalle Valo wrote: > Konrad Dybcio writes: > >> On 21.11.2022 14:56, Linus Walleij wrote: >>> On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio wrote: >>> >>>> I can think of a couple of hacky ways to force use of 43596 fw, but I >>>> don't think any would be really upstreamable.. >>> >>> If it is only known to affect the Sony Xperias mentioned then >>> a thing such as: >>> >>> if (of_machine_is_compatible("sony,xyz") || >>> of_machine_is_compatible("sony,zzz")... ) { >>> // Enforce FW version >>> } >>> >>> would be completely acceptable in my book. It hammers the >>> problem from the top instead of trying to figure out itsy witsy >>> details about firmware revisions. >>> >>> Yours, >>> Linus Walleij >> >> Actually, I think I came up with a better approach by pulling a page >> out of Asahi folks' book - please take a look and tell me what you >> think about this: >> >> [1] >> https://github.com/SoMainline/linux/commit/4b6fccc995cd79109b0dae4e4ab2e48db97695e7 >> [2] >> https://github.com/SoMainline/linux/commit/e3ea1dc739634f734104f37fdbed046873921af7 > > Instead of a directory path ("brcm/brcmfmac43596-pcie") why not provide > just the chipset name ("brcmfmac43596-pcie")? IMHO it's unnecessary to > have directory names in Device Tree. I think it's common practice to include a full $FIRMWARE_DIR-relative path when specifying firmware in DT, though here I left out the board name bit as that's assigned dynamically anyway. That said, if you don't like it, I can change it. Konrad >