From: "luobin (L)" <luobin9@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>,
<chiqijun@huawei.com>
Subject: Re: [PATCH net-next v2 1/2] hinic: add support to handle hw abnormal event
Date: Tue, 21 Jul 2020 09:24:17 +0800 [thread overview]
Message-ID: <fc2ee43e-8342-0b9f-6cc1-4eb19cbb93f5@huawei.com> (raw)
In-Reply-To: <20200720111326.301b6d74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2020/7/21 2:13, Jakub Kicinski wrote:
> On Sat, 18 Jul 2020 16:58:29 +0800 Luo bin wrote:
>> add support to handle hw abnormal event such as hardware failure,
>> cable unplugged,link error
>>
>> Signed-off-by: Luo bin <luobin9@huawei.com>
>> ---
>> V1~V2: add link extended state
>> V0~V1: fix auto build test WARNING
>
> I don't understand what you think devlink health is missing.
>
> If it is really missing some functionality you require you have to work
> on extending it.
>
> Dumping error event state into kernel logs when we have specific
> infrastructure built to address this sort of needs won't fly.
> .
>
Okay, I'll try to implement these functionality based on devlink health.
next prev parent reply other threads:[~2020-07-21 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 8:58 [PATCH net-next v2 0/2] hinic: add some error messages for debug Luo bin
2020-07-18 8:58 ` [PATCH net-next v2 1/2] hinic: add support to handle hw abnormal event Luo bin
2020-07-20 18:13 ` Jakub Kicinski
2020-07-21 1:24 ` luobin (L) [this message]
2020-07-18 8:58 ` [PATCH net-next v2 2/2] hinic: add log in exception handling processes Luo bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc2ee43e-8342-0b9f-6cc1-4eb19cbb93f5@huawei.com \
--to=luobin9@huawei.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).